From Koha home click 'Circulation' then 'Check out' You are on a page with a header search, but no content, this can be odd For contrast: 'Circulation' -> 'Check in' You have a form in the page to return items
Created attachment 178092 [details] [review] Bug 39141: Add a patron search box on Circulation - Checkout This patch adds a search box when visiting the check out page before a patron has been selected To test: 1 - From Koha home browse to Circulation -> Check out 2 - Note an empty page, though you have the header search forms 3 - Apply patch 4 - Repeate above - now you have a patron search box 5 - Search by name or cardnumber 6 - Confirm search works as expected 7 - Sign off!
Created attachment 178095 [details] [review] Bug 39141: (follow-up) Style input and add autocomplete This patch adds some friendly styling to the new form and adds autocomplete functionality.
Created attachment 178121 [details] [review] Bug 39141: Add a patron search box on Circulation - Checkout This patch adds a search box when visiting the check out page before a patron has been selected To test: 1 - From Koha home browse to Circulation -> Check out 2 - Note an empty page, though you have the header search forms 3 - Apply patch 4 - Repeate above - now you have a patron search box 5 - Search by name or cardnumber 6 - Confirm search works as expected 7 - Sign off! Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Created attachment 178122 [details] [review] Bug 39141: (follow-up) Style input and add autocomplete This patch adds some friendly styling to the new form and adds autocomplete functionality. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Why not use patron-search-box.inc ? And its permissions check? Also note that it includes an id="findborrower". Why do you change to findborrower_main: - <input autocomplete="off" id="findborrower" name="findborrower" type="text" placeholder="Enter patron card number or partial name" size="40" /> + <input autocomplete="off" id="findborrower_main" name="findborrower" type="text" placeholder="Enter patron card number or partial name" size="40" /> Needs feedback
(In reply to Marcel de Rooy from comment #5) > Why not use patron-search-box.inc ? And its permissions check? The markup in patron-search-box.inc is specific to the header search tabs and cannot be easily reused here.
Shouldn't we try and reuse the tool used in reserve/request.pl ? It might be improved in a separate patch later if you don't want to now ; this works and is a good increment. At the moment please reuse the styles used in "check in" for the barcode.
Adjusted the title that referred to Check in
Created attachment 179318 [details] [review] Bug 39141: Add a patron search box on Circulation - Checkout This patch adds a search box when visiting the check out page before a patron has been selected To test: 1 - From Koha home browse to Circulation -> Check out 2 - Note an empty page, though you have the header search forms 3 - Apply patch 4 - Repeate above - now you have a patron search box 5 - Search by name or cardnumber 6 - Confirm search works as expected 7 - Sign off! Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 179319 [details] [review] Bug 39141: (follow-up) Style input and add autocomplete This patch adds some friendly styling to the new form and adds autocomplete functionality. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
(In reply to Baptiste Wojtkowski (bwoj) from comment #7) > Shouldn't we try and reuse the tool used in reserve/request.pl ? It might be > improved in a separate patch later if you don't want to now ; this works and > is a good increment. > > At the moment please reuse the styles used in "check in" for the barcode. Lets do further improvements on follow-up reports.
As this has been like this forever, I feel it qualifies more as an enhancement.
I made the page heading "Check out" to match the name on the Circulation page and also consistent with "Check in".
Pushed for 25.05! Well done everyone, thank you!