We all love bug 14004 and its fun tools for loading pages without JS or CSS from sysprefs. We'd like to extend that idea to toggles that would appear on every page to turn UserJS and UserCSS on and off. We'd tie those toggles to a new "debug" permission, so only users with that permission will be shown those toggles.
Created attachment 178123 [details] [review] Bug 39142 Add debug permission to allow user to toggle JS and CSS customizations on/off Database changes for 39142
Created attachment 178294 [details] [review] Bug 39142: Add debug permission to allow user to toggle JS and CSS customizations on/off to test: 1. apply the patch 2. use updatedatabase run to update your db 3. add custom JS and CSS in the IntranetUserJS and IntranetUserCSS fields 4. with as SuperLibrarian account confirm you have 3 buttons at the bottom of your screen, Disable User JS, Disable User CSS, and load only default stylesheets 5. clicking the buttons should reload the current page with a query to disable those things. 6. Log in as a user that is not a superlibrarian and does not have the debug UI permission enabled 7. confirm the buttons are no longer visible 8. Add the debug UI permission to the user 9. confirm the debug buttons are now visible for that user.
Created attachment 178481 [details] [review] Bug 39142 Add debug permission to allow user to toggle JS and CSS customizations on/off Database changes for 39142 Signed-off-by: Lari Strand <lari.strand@koha-suomi.fi>
Created attachment 178482 [details] [review] Bug 39142: Add debug permission to allow user to toggle JS and CSS customizations on/off to test: 1. apply the patch 2. use updatedatabase run to update your db 3. add custom JS and CSS in the IntranetUserJS and IntranetUserCSS fields 4. with as SuperLibrarian account confirm you have 3 buttons at the bottom of your screen, Disable User JS, Disable User CSS, and load only default stylesheets 5. clicking the buttons should reload the current page with a query to disable those things. 6. Log in as a user that is not a superlibrarian and does not have the debug UI permission enabled 7. confirm the buttons are no longer visible 8. Add the debug UI permission to the user 9. confirm the debug buttons are now visible for that user. Signed-off-by: Lari Strand <lari.strand@koha-suomi.fi>
Just a thought, we use multiple Koha plugins that inject Javascript or CSS to the intranet views (subs intranet_js/css in plugin main modules). The plugins can always be disabled but maybe it should be considered as an option in this new feature?
A possible future enhancement to enable that maybe setting up a plugin hook for plugins to either add to the query string generated by the debug buttons here or add debug buttons of their own.