Custom CSS is not applied to the OPAC virtual card page (opac-virtual-card.pl). To replicate: 1. Set OPACVirtualCard syspref to Allow 2. Add an obvious change to OPACUserCSS syspref ( body {background-color: pink;} ) 3. Switch to the OPAC, notice the CSS is in effect 4. Log in and go to 'Your account' then 'My virtual card' from the menu on the left 5. Notice the custom CSS is no longer in effect
Good catch! Funny story... it looks like OPACUserCSS is being rendered in the HTML, but the OPAC virtual card page mistakenly applies the opac.css twice. Once before and once after OPACUserCSS.
Created attachment 178129 [details] [review] Bug 39144: Remove second call to opac.css This change removes an unnecessary second call to opac.css on the opac-virtual-card.pl page. Test plan: 1. Set OPACVirtualCard syspref to Allow 2. Add an obvious change to OPACUserCSS syspref ( body {background-color: pink;} ) 3. Switch to the OPAC, notice the CSS is in effect 4. Log in and go to 'Your account' then 'My virtual card' from the menu on the left 5. Notice the custom CSS affects the virtual card page too
Created attachment 178300 [details] [review] Bug 39144: Remove second call to opac.css This change removes an unnecessary second call to opac.css on the opac-virtual-card.pl page. Test plan: 1. Set OPACVirtualCard syspref to Allow 2. Add an obvious change to OPACUserCSS syspref ( body {background-color: pink;} ) 3. Switch to the OPAC, notice the CSS is in effect 4. Log in and go to 'Your account' then 'My virtual card' from the menu on the left 5. Notice the custom CSS affects the virtual card page too Signed-off-by: David Nind <david@davidnind.com>
Created attachment 178450 [details] [review] Bug 39144: Remove second call to opac.css This change removes an unnecessary second call to opac.css on the opac-virtual-card.pl page. Test plan: 1. Set OPACVirtualCard syspref to Allow 2. Add an obvious change to OPACUserCSS syspref ( body {background-color: pink;} ) 3. Switch to the OPAC, notice the CSS is in effect 4. Log in and go to 'Your account' then 'My virtual card' from the menu on the left 5. Notice the custom CSS affects the virtual card page too Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed for 25.05! Well done everyone, thank you!