Bug 39159 - Remove useless autouse in C4/Koha.pm
Summary: Remove useless autouse in C4/Koha.pm
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: David Cook
QA Contact: Lisette Scheer
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2025-02-19 01:32 UTC by David Cook
Modified: 2025-03-07 14:43 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39159: Remove useless autouse line (766 bytes, patch)
2025-02-19 05:15 UTC, David Cook
Details | Diff | Splinter Review
Bug 39159: Remove useless autouse line (863 bytes, patch)
2025-02-26 08:18 UTC, Magnus Enger
Details | Diff | Splinter Review
Bug 39159: Remove useless autouse line (926 bytes, patch)
2025-02-28 18:16 UTC, Lisette Scheer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2025-02-19 01:32:54 UTC
I just noticed the following line in C4/Koha.pm:

use autouse 'Data::cselectall_arrayref' => qw(Dumper);

It looks like a mistake added by bug 10937
Comment 1 David Cook 2025-02-19 05:15:25 UTC Comment hidden (obsolete)
Comment 2 Magnus Enger 2025-02-26 08:18:28 UTC
Created attachment 178704 [details] [review]
Bug 39159: Remove useless autouse line

This patch removes a useless autouse line.

Test plan:
0. Apply the patch
1. koha-plack --restart kohadev
2. Go to http://localhost:8081/cgi-bin/koha/mainpage.pl
3. Nothing blows up

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Followed the test plan, works as advertised.
Comment 3 Lisette Scheer 2025-02-28 18:16:44 UTC
Created attachment 178869 [details] [review]
Bug 39159: Remove useless autouse line

This patch removes a useless autouse line.

Test plan:
0. Apply the patch
1. koha-plack --restart kohadev
2. Go to http://localhost:8081/cgi-bin/koha/mainpage.pl
3. Nothing blows up

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Followed the test plan, works as advertised.
Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Comment 4 Katrin Fischer 2025-03-07 14:43:00 UTC
Pushed for 25.05!

Well done everyone, thank you!