It would be handy if the exception carried the 'wrong format passed' which happens to be available in the context the exception is thrown.
Created attachment 178616 [details] [review] Bug 39191: Add `format` parameter to Koha::Exceptions::ArticleRequest::WrongFormat This patch just adds a new parameter so any exception consumer or even the logs contain more information about the context in which the exception was thrown. This would be useful debugging issues. No behavior change in Koha. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/Koha/ArticleRequest.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 2 => SUCCESS: Tests pass! 4. Sign off :-D
Created attachment 180397 [details] [review] Bug 39191: Add `format` parameter to Koha::Exceptions::ArticleRequest::WrongFormat This patch just adds a new parameter so any exception consumer or even the logs contain more information about the context in which the exception was thrown. This would be useful debugging issues. No behavior change in Koha. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/Koha/ArticleRequest.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 2 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Trivial, clear improvement.. works as expected. Passing QA
Pushed for 25.05! Well done everyone, thank you!