Bug 39200 - Fix QA tool complaint that hidelostitems is badly placed in sysprefs.sql
Summary: Fix QA tool complaint that hidelostitems is badly placed in sysprefs.sql
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Emily Lamancusa (emlam)
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-02-25 21:09 UTC by Emily Lamancusa (emlam)
Modified: 2025-03-14 15:03 UTC (History)
1 user (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39200: Fix syspref order (2.09 KB, patch)
2025-02-25 21:11 UTC, Emily Lamancusa (emlam)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Emily Lamancusa (emlam) 2025-02-25 21:09:40 UTC
Any time a patch touches sysprefs.sql, the QA tool returns a "not blocker" failure that the syspref hidelostitems is badly placed. Really the problem is the previous line, hide_marc - the QA tool wants the underscore to be alphabetized after letters, not before.
Comment 1 Emily Lamancusa (emlam) 2025-02-25 21:11:10 UTC
Created attachment 178697 [details] [review]
Bug 39200: Fix syspref order

Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 2 Emily Lamancusa (emlam) 2025-02-25 21:11:44 UTC
Trivial patch; self-so
Comment 3 Katrin Fischer 2025-02-26 12:07:16 UTC
Hm, the problem seems to have moved on now:

 FAIL	installer/data/mysql/mandatory/sysprefs.sql
   FAIL	  sysprefs_order
		Not blocker: Sysprefs IntranetAddMastheadLibraryPulldown is bad placed (see bug 10610)

Adding follow-up.
Comment 4 Marcel de Rooy 2025-03-14 10:52:18 UTC
No changes -- Patch already applied.

Can this be closed ? If not, please reopen.
Comment 5 Katrin Fischer 2025-03-14 15:03:47 UTC
Thanks Marcel. Updating the other fields now as well.