The "test session driver" unit test assume SessionStorage is set to MySQL and will fail if it is set to anything else. We should mock the values, and test the other supported values.
Created attachment 178816 [details] [review] Bug 39214: Mock preferences in t/db_dependent/Koha/Session.t for subtest 'test session driver' The "test session driver" unit test assume SessionStorage is set to MySQL and will fail if it is set to anything else. We should mock the values, and test the other supported values. Test Plan: 1) Set SessionStorage to File 2) prove t/db_dependent/Koha/Session.t 3) Note test failure 4) prove t/db_dependent/Koha/Session.t 5) Tests pass!
Created attachment 178821 [details] [review] Bug 39214: Mock preferences in t/db_dependent/Koha/Session.t for subtest 'test session driver' The "test session driver" unit test assume SessionStorage is set to MySQL and will fail if it is set to anything else. We should mock the values, and test the other supported values. Test Plan: 1) Set SessionStorage to File 2) prove t/db_dependent/Koha/Session.t 3) Note test failure 4) prove t/db_dependent/Koha/Session.t 5) Tests pass! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
New tests are added. Tests pass, I reproduced the failure.
Pushed for 25.05! Well done everyone, thank you!