Bug 39250 - Add archive_purchase_suggestions.pl to cron.daily commented
Summary: Add archive_purchase_suggestions.pl to cron.daily commented
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Marcel de Rooy
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-03-05 13:16 UTC by Marcel de Rooy
Modified: 2025-03-07 14:43 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39250: Add archive_purchase_suggestions.pl to cron.daily commented (2.29 KB, patch)
2025-03-05 13:31 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 39250: Add archive_purchase_suggestions.pl to cron.daily commented (2.32 KB, patch)
2025-03-07 12:10 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2025-03-05 13:16:36 UTC
A commented cron job reminds admins of its existence and potential use. It can be easily enabled automatically with a sed statement in a Docker file or so.

This patch deals with archive_purchase_suggestions.pl (which came with 20.05)
Comment 1 Marcel de Rooy 2025-03-05 13:31:57 UTC
Created attachment 178969 [details] [review]
Bug 39250: Add archive_purchase_suggestions.pl to cron.daily commented

It will be a commented line in the debian template and added also
in the crontab.example file.
As mentioned on BZ, the comment can easily be removed automatically
during Docker builds or startups etc.

Test plan:
Just read the patch. Nothing changes here actually.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2025-03-05 13:32:33 UTC
Actually nothing to test. Pushing it a level further.
Comment 3 Martin Renvoize (ashimema) 2025-03-07 12:10:20 UTC
Created attachment 179068 [details] [review]
Bug 39250: Add archive_purchase_suggestions.pl to cron.daily commented

It will be a commented line in the debian template and added also
in the crontab.example file.
As mentioned on BZ, the comment can easily be removed automatically
during Docker builds or startups etc.

Test plan:
Just read the patch. Nothing changes here actually.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize (ashimema) 2025-03-07 12:10:47 UTC
Trivial improvement, no regressions, no tests required, no qa script failures..

Passing QA
Comment 5 Katrin Fischer 2025-03-07 14:43:12 UTC
Pushed for 25.05!

Well done everyone, thank you!