Bug 39261 - Category charge limits are integers in db but decimals in form
Summary: Category charge limits are integers in db but decimals in form
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: 24.11
Hardware: All All
: P5 - low minor
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 28924
Blocks:
  Show dependency treegraph
 
Reported: 2025-03-06 00:04 UTC by Eric Phetteplace
Modified: 2025-03-06 09:09 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Phetteplace 2025-03-06 00:04:16 UTC
The noissuescharge, noissueschargeguarantees, and noissueschargeguarantorswithguarantees columns for patron categories are INT 10 in the database but presented as currency units with decimals in staff interface. The form inputs are presented on the /koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt template.

For instance, if you save a patron category's "noissuescharge" value as "50.50" it is rounded up to "51" in the database. This is unanticipated behavior for administrators.

The alternative to making database changes is to remove the $Price on_editing filters from the template, the decimal pattern regex, and make it clear that these are integers representing a currency unit. This is obviously easier but I don't know how important decimal charges are to other libraries (we could do fine without them). The "noissuescharge" syspref is an integer.