In a single-branch Koha installation it makes no sense to have library selection dropdown in the self registration form.
The drop-down was hidden in Bug 27618 but reintroduced by regression from Bug 29859. https://github.com/Koha-Community/Koha/commit/d02e91f2694b7642282e124a871a8b6ebcde1055#diff-d9a6af2df2cc64675ffd2b565a4dcc7865d4be977545d5dd2b5ad1b4c4532b80L248
Created attachment 179017 [details] [review] Bug 39265: Hide library drop-down from opac-memberentry if there is only one library To test, apply the patch and enable PatronSelfRegistration. - Modify the PatronSelfRegistrationLibraryList system preference to include only one library. - Go to the self-registratoin page in the OPAC. - Under "Home library," you should see the library name. If you inspect the source you should see the library branchcode in a hidden form. - Confirm that the form submission includes the correct library information.
Created attachment 179018 [details] [review] Bug 39265: Hide library drop-down from opac-memberentry if there is only one library To test, apply the patch and enable PatronSelfRegistration. - Modify the PatronSelfRegistrationLibraryList system preference to include only one library. - Go to the self-registratoin page in the OPAC. - Under "Home library," you should see the library name. If you inspect the source you should see the library branchcode in a hidden form. - Confirm that the form submission includes the correct library information. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 179166 [details] [review] Bug 39265: Hide library drop-down from opac-memberentry if there is only one library To test, apply the patch and enable PatronSelfRegistration. - Modify the PatronSelfRegistrationLibraryList system preference to include only one library. - Go to the self-registratoin page in the OPAC. - Under "Home library," you should see the library name. If you inspect the source you should see the library branchcode in a hidden form. - Confirm that the form submission includes the correct library information. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(In reply to Lari Taskula from comment #1) > The drop-down was hidden in Bug 27618 but reintroduced by regression from > Bug 29859. > > https://github.com/Koha-Community/Koha/commit/ > d02e91f2694b7642282e124a871a8b6ebcde1055#diff- > d9a6af2df2cc64675ffd2b565a4dcc7865d4be977545d5dd2b5ad1b4c4532b80L248 Thanks for this detective work! I had a feeling we had this before, this really helps.
Pushed for 25.05! Well done everyone, thank you!