There is an issue with the "Your Lists" and "Public Lists" tabs where the list content doesn't update correctly when switching between them. Initially, the lists display correctly. However, when a user clicks between the tabs (e.g., from 'Public Lists' to 'Private Lists' or vice versa), the list content remains stuck on the first tab's content. For instance, if a user starts on the 'Private Lists' tab and switches to the 'Public Lists' tab, the lists from 'Private Lists' continue to display even though the 'Public Lists' tab is selected. Similarly, if a user switches from 'Public Lists' to 'Private Lists', the 'Public Lists' remain visible. This issue persists until the page is refreshed, at which point the lists reset, but the same behavior occurs again upon switching tabs. This causes confusion, especially for staff who need to view both private and public lists and expect the tab content to reflect the selected tab.
Created attachment 179020 [details] [review] Bug 39268: Fix tab switching on lists page This patch fixes broken tab switching on the staff interface lists page. It was broken by the upgrade to Bootstrap 5. To test, apply the patch and go to the Lists page in the staff interface. - If necessary, create multiple public and private lists. - Confirm that switching between the "Your lists" tab and the "Public lists" tab works correctly. - Try using URL parameters to load each tab: http://127.0.0.1:8081/cgi-bin/koha/virtualshelves/shelves.pl?op=list&public=0 http://127.0.0.1:8081/cgi-bin/koha/virtualshelves/shelves.pl?op=list&public=1 Sponsored-by: Athens County Public Libraries
Created attachment 179022 [details] [review] Bug 39268: Fix tab switching on lists page This patch fixes broken tab switching on the staff interface lists page. It was broken by the upgrade to Bootstrap 5. To test, apply the patch and go to the Lists page in the staff interface. - If necessary, create multiple public and private lists. - Confirm that switching between the "Your lists" tab and the "Public lists" tab works correctly. - Try using URL parameters to load each tab: http://127.0.0.1:8081/cgi-bin/koha/virtualshelves/shelves.pl?op=list&public=0 http://127.0.0.1:8081/cgi-bin/koha/virtualshelves/shelves.pl?op=list&public=1 Sponsored-by: Athens County Public Libraries Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 179099 [details] [review] Bug 39268: Fix tab switching on lists page This patch fixes broken tab switching on the staff interface lists page. It was broken by the upgrade to Bootstrap 5. To test, apply the patch and go to the Lists page in the staff interface. - If necessary, create multiple public and private lists. - Confirm that switching between the "Your lists" tab and the "Public lists" tab works correctly. - Try using URL parameters to load each tab: http://127.0.0.1:8081/cgi-bin/koha/virtualshelves/shelves.pl?op=list&public=0 http://127.0.0.1:8081/cgi-bin/koha/virtualshelves/shelves.pl?op=list&public=1 Sponsored-by: Athens County Public Libraries Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Pushed for 25.05! Well done everyone, thank you!
Greatly appreciated if this could be backported to 24.11! Cheers and thank you!
Nice work everyone! Pushed to 24.11.x for 24.11.03