Bug 39280 - Generalize ODUE notice text - remove "If an item becomes more than 30 days overdue, you will be unable to use your library card until the item is returned."
Summary: Generalize ODUE notice text - remove "If an item becomes more than 30 days ov...
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: sasha.anastasi+bugzilla
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2025-03-07 20:16 UTC by Katrin Fischer
Modified: 2025-07-20 23:22 UTC (History)
3 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement removes unnecessary or misleading text from the ODUE notice, as it depends on the library's settings: "If an item becomes more than 30 days overdue, you will be unable to use your library card until the item is returned.". Note: The notice is not automatically updated for existing installations. Update the notice manually to change the wording if required, or replace the default notice using "View default" and "Copy to template" if you have not customized the notice.
Version(s) released in:
Circulation function:


Attachments
Bug 39280: remove misleading message text (1.08 KB, patch)
2025-07-17 22:15 UTC, sasha.anastasi+bugzilla
Details | Diff | Splinter Review
Bug 39280: remove misleading message text (1.13 KB, patch)
2025-07-17 22:35 UTC, David Nind
Details | Diff | Splinter Review
Bug 39280: Remove misleading message text for ODUE notice (1.95 KB, patch)
2025-07-20 21:50 UTC, Aleisha Amohia
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2025-03-07 20:16:09 UTC
The notice makes an assumption about the configuration that might not always be true:

If an item becomes more than 30 days overdue, you will be unable to use your library card until the item is returned.

installer/data/mysql/en/mandatory/sample_notices.yml:letter:1:row:32:mul:15

It would be better to rephrase to make it more general.
Comment 1 Aleisha Amohia 2025-07-14 01:18:43 UTC
Notice code: ODUE

I would suggest we just remove this line. The notice already requests the user to return or renew ASAP, which probably does enough for a template.
Comment 2 sasha.anastasi+bugzilla 2025-07-17 22:15:50 UTC
Created attachment 184245 [details] [review]
Bug 39280: remove misleading message text

Test plan:
1. refresh database
2. verify ODUE notice text does not include the line "If an item becomes more than 30 days overdue, you will be unable to use your library card until the item is returned."
Comment 3 David Nind 2025-07-17 22:35:58 UTC
Created attachment 184250 [details] [review]
Bug 39280: remove misleading message text

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2025-07-17 22:53:51 UTC
Hi Sasha.

Nice work!

I've signed off, as it does what it says in the test plan.

For some reason, the test plan is not included in the signed off commit message when I attached it, so you will need to amend the commit message.

I would suggest rewording the commit message to help it pass QA, following the commit message guidelines https://wiki.koha-community.org/wiki/Commit_messages 

Suggested wording:

---
Bug 39280: Remove misleading message text for ODUE notice

This patch removes unnecessary and misleading wording from the overdue note as it depends on the library's circulation rules: "If an item becomes more than 30 days overdue, you will be unable to use your library card until the item is returned."

Test plan:
1. Check the wording of the ODUE notice under Tools > Patrons and circulation > Notices and slips.
2. Note that it includes this wording, which may be unnecessary or misleading depending on the library's settings: "If an item becomes more than 30 days overdue, you will be unable to use your library card until the item is returned."
3. Apply the patch.
4. Check that the updated ODUE notice has removed the wording by either:
   4.1 Resetting everything: reset_all
   4.2 Viewing the default notice - click "View default" when viewing the email notice
5. Sign off.
---

I've also added a release note.

David Nind
Comment 5 Aleisha Amohia 2025-07-20 21:50:57 UTC
Created attachment 184420 [details] [review]
Bug 39280: Remove misleading message text for ODUE notice

This patch removes unnecessary and misleading wording from the overdue note as it depends on the library's circulation rules: "If an item becomes more than 30 days overdue, you will be unable to use your library card until the item is returned."

Test plan:
1. Check the wording of the ODUE notice under Tools > Patrons and circulation > Notices and slips.
2. Note that it includes this wording, which may be unnecessary or misleading depending on the library's settings: "If an item becomes more than 30 days overdue, you will be unable to use your library card until the item is returned."
3. Apply the patch.
4. Check that the updated ODUE notice has removed the wording by either:
   4.1 Resetting everything: reset_all
   4.2 Viewing the default notice - click "View default" when viewing the email notice
5. Sign off.

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 Aleisha Amohia 2025-07-20 21:51:45 UTC
(In reply to David Nind from comment #4)
> Hi Sasha.
> 
> Nice work!
> 
> I've signed off, as it does what it says in the test plan.
> 
> For some reason, the test plan is not included in the signed off commit
> message when I attached it, so you will need to amend the commit message.
> 

Thanks so much David, I have done this on Sasha's behalf!
Comment 7 David Nind 2025-07-20 23:22:23 UTC
(In reply to Aleisha Amohia from comment #6)
> (In reply to David Nind from comment #4)
> > Hi Sasha.
> > 
> > Nice work!
> > 
> > I've signed off, as it does what it says in the test plan.
> > 
> > For some reason, the test plan is not included in the signed off commit
> > message when I attached it, so you will need to amend the commit message.
> > 
> 
> Thanks so much David, I have done this on Sasha's behalf!

Thanks Aleisha!