To recreate: 1. Have a patron with a middle name 2. Do a patron search that brings them up, no middle name appears
Created attachment 179174 [details] [review] Bug 39283: Concat middle name with preffered name if it exists 1. Have a patron with a middle name 2. Do a patron search that brings them up, no middle name appears 3. APPLY PATCH 4. Try again, middle name should appear in patron searches.
Created attachment 179469 [details] [review] Bug 39283: Concat middle name with preffered name if it exists 1. Have a patron with a middle name 2. Do a patron search that brings them up, no middle name appears 3. APPLY PATCH 4. Try again, middle name should appear in patron searches. Signed-off-by: SympoKoha <thibault.keromnes@univ-paris8.fr>
Sandboxes had a bug and put another signed-off The correct one is : Signed-off-by: Bibliothèque Ifao <bibliotheque@ifao.egnet.net>
Created attachment 179563 [details] [review] Bug 39283: Concat middle name with preffered name if it exists 1. Have a patron with a middle name 2. Do a patron search that brings them up, no middle name appears 3. APPLY PATCH 4. Try again, middle name should appear in patron searches. QA follow-up: made the same fix inline for other_name Signed-off-by: Bibliothèque Ifao <bibliotheque@ifao.egnet.net> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Good catch, thanks Lucas! There was another spot a few lines down where other_names had the same issue, so I went ahead and fixed that inline as well.
Pushed for 25.05! Well done everyone, thank you!
Nice work everyone! Pushed to 24.11.x for 24.11.04
Not backporting to 22.11.x as it wasn't backported to 24.05.x