Bug 39300 - Quick edit a subfield not selecting the correct tab
Summary: Quick edit a subfield not selecting the correct tab
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Julian Maurice
URL:
Keywords:
Depends on: 17173 33178
Blocks:
  Show dependency treegraph
 
Reported: 2025-03-11 09:37 UTC by Jonathan Druart
Modified: 2025-04-10 17:27 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39300: Fix quick edit of subfields (1.67 KB, patch)
2025-03-11 09:39 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 39300: Fix quick edit of subfields (1.72 KB, patch)
2025-03-11 11:25 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 39300: Fix quick edit of subfields (1.78 KB, patch)
2025-04-03 08:06 UTC, Julian Maurice
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2025-03-11 09:37:14 UTC
Searching tag$subfield in the framework should redirect to the edition of the tag with the subfield tab selected.
This has been broken when we used the wrapper for tabs on bug 33178.
Comment 1 Jonathan Druart 2025-03-11 09:39:28 UTC
Created attachment 179150 [details] [review]
Bug 39300: Fix quick edit of subfields

Searching tag$subfield in the framework should redirect to the edition of the tag with the subfield tab selected.
This has been broken when we used the wrapper for tabs on bug 33178.

Test plan:
Edit a framework
http://localhost:8081/cgi-bin/koha/admin/marctagstructure.pl?frameworkcode=
Search for 952$c
=> You are redirected to the edition of 952 and the "c" tab is selected
Comment 2 Owen Leonard 2025-03-11 11:25:24 UTC
Created attachment 179159 [details] [review]
Bug 39300: Fix quick edit of subfields

Searching tag$subfield in the framework should redirect to the edition
of the tag with the subfield tab selected.
This has been broken when we used the wrapper for tabs on bug 33178.

Test plan:
Edit a framework
http://localhost:8081/cgi-bin/koha/admin/marctagstructure.pl?frameworkcode=
Search for 952$c
=> You are redirected to the edition of 952 and the "c" tab is selected

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Julian Maurice 2025-04-03 08:06:37 UTC
Created attachment 180434 [details] [review]
Bug 39300: Fix quick edit of subfields

Searching tag$subfield in the framework should redirect to the edition
of the tag with the subfield tab selected.
This has been broken when we used the wrapper for tabs on bug 33178.

Test plan:
Edit a framework
http://localhost:8081/cgi-bin/koha/admin/marctagstructure.pl?frameworkcode=
Search for 952$c
=> You are redirected to the edition of 952 and the "c" tab is selected

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Comment 4 Katrin Fischer 2025-04-10 17:27:56 UTC
Pushed for 25.05!

Well done everyone, thank you!