Bug 39407 - Having no active currency defined breaks SIP silently
Summary: Having no active currency defined breaks SIP silently
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: SIP2 (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Kyle M Hall (khall)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-03-21 10:51 UTC by Kyle M Hall (khall)
Modified: 2025-03-21 11:12 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 39407: Add unit test to prove no active currency crashes SIP (1.64 KB, patch)
2025-03-21 11:05 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 39407: Add unit test to prove no active currency crashes SIP (1.64 KB, patch)
2025-03-21 11:11 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 39407: Prevent SIP from crashing due to lack of active currency (1.47 KB, patch)
2025-03-21 11:11 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall (khall) 2025-03-21 10:51:19 UTC
In the staff interface, in most areas of Koha that require an active currency to be defined, a large info box appears to let the user know there is no active currency defined. Our SIP code presumes an active currency and if one is not defined, any SIP messages utilizing C4::SIP::ILS::Patron will crash with no errors such that a response is never transmitted for the request.
Comment 1 Kyle M Hall (khall) 2025-03-21 11:05:21 UTC
Created attachment 179583 [details] [review]
Bug 39407: Add unit test to prove no active currency crashes SIP
Comment 2 Kyle M Hall (khall) 2025-03-21 11:11:53 UTC
Created attachment 179584 [details] [review]
Bug 39407: Add unit test to prove no active currency crashes SIP
Comment 3 Kyle M Hall (khall) 2025-03-21 11:11:59 UTC
Created attachment 179585 [details] [review]
Bug 39407: Prevent SIP from crashing due to lack of active currency

In the staff interface, in most areas of Koha that require an active currency to be defined, a large info box appears to let the user know there is no active currency defined. Our SIP code presumes an active currency and if one is not defined, any SIP messages utilizing C4::SIP::ILS::Patron will crash with no errors such that a response is never transmitted for the request.

Test Plan:
1) Apply the unit test patch
2) prove t/db_dependent/SIP/Patron.t Fails!
3) Apply the second patch
4) prove t/db_dependent/SIP/Patron.t Succeeds!