When https://git.koha-community.org/Koha-community/Koha/commit/74d7ae7672a4b82568e57eaddefbded4bf5b05e6 added forms for batch modify and batch delete items so they would work with CSRF protection, it clearly did so by copy-pasting the form from Modify record using template, since all three have id="modifybiblio". Luckily, the copies have their own id attribute first, so the duplicate ones are dropped by parsers since an element can't have two ids, but having duplicates is confusing.
Created attachment 179616 [details] [review] Bug 39409: Duplicate modifybiblio ids in cat-toolbar The biblio details page Edit menu has three different elements which all have id="modifybibilio", two of which also have another id. Neither of those things is allowed. Test plan: 1. Without the patch, load the details view for any biblio record and View source 2. Search for id="modifybiblio" 3. You will get three results, the second and third shown with id in red 4. Apply patch, reload the page, View source and search again 5. You will get one result, without any red Sponsored-by: Chetco Community Public Library
Created attachment 179637 [details] [review] Bug 39409: Duplicate modifybiblio ids in cat-toolbar The biblio details page Edit menu has three different elements which all have id="modifybibilio", two of which also have another id. Neither of those things is allowed. Test plan: 1. Without the patch, load the details view for any biblio record and View source 2. Search for id="modifybiblio" 3. You will get three results, the second and third shown with id in red 4. Apply patch, reload the page, View source and search again 5. You will get one result, without any red Sponsored-by: Chetco Community Public Library Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Trivial, skipping QA.
Pushed for 25.05! Well done everyone, thank you!