When editing an existing booking, the Patron, Pickup at, and Item are retained, but the Itemtype will be de-selected. The booking cannot be edited until the item type is re-selected. The booking dates are also not retained in the edit booking window, but this was existing behavior. To re-create: 1. Place a booking on an item. 2. Click on edit to open the Edit booking modal. 3. The item type will be de-selected, and the booking dates calendar will be locked until the item type is re-selected.
Confirmed in main.
Created attachment 181295 [details] [review] Bug 39414: Retain item type selection when editing a booking To test: 1. Place a booking on an item. 2. Click on edit to open the Edit booking modal. 3. The item type will be de-selected, and the booking dates calendar will be locked until the item type is re-selected. 4. APPLY PATCH 5. Try steps 1 - 3 again, this time the proper item type should be selected and the date field will not be locked. 6. Try creating a new booking, making sure everything still works as excepted.
Created attachment 181377 [details] [review] Bug 39414: Retain item type selection when editing a booking To test: 1. Place a booking on an item. 2. Click on edit to open the Edit booking modal. 3. The item type will be de-selected, and the booking dates calendar will be locked until the item type is re-selected. 4. APPLY PATCH 5. Try steps 1 - 3 again, this time the proper item type should be selected and the date field will not be locked. 6. Try creating a new booking, making sure everything still works as excepted. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Going straight for a QA here.. trivial oversight fixed, thanks Lucas for the fix and Kristi for the report. Passing QA
Pushed for 25.05! Well done everyone, thank you!
Any chance of this as a backport to 24.11?