Bug 39414 - Item type not retained when editing a booking
Summary: Item type not retained when editing a booking
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Lucas Gass (lukeg)
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords: rel_24_11_candidate
Depends on:
Blocks:
 
Reported: 2025-03-21 17:21 UTC by Kristi
Modified: 2025-04-29 20:01 UTC (History)
5 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function: Bookings


Attachments
Bug 39414: Retain item type selection when editing a booking (4.10 KB, patch)
2025-04-22 15:54 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 39414: Retain item type selection when editing a booking (4.16 KB, patch)
2025-04-23 14:25 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kristi 2025-03-21 17:21:04 UTC
When editing an existing booking, the Patron, Pickup at, and Item are retained, but the Itemtype will be de-selected. The booking cannot be edited until the item type is re-selected.

The booking dates are also not retained in the edit booking window, but this was existing behavior.

To re-create:
1. Place a booking on an item.
2. Click on edit to open the Edit booking modal.
3. The item type will be de-selected, and the booking dates calendar will be locked until the item type is re-selected.
Comment 1 Lucas Gass (lukeg) 2025-04-22 14:41:04 UTC
Confirmed in main.
Comment 2 Lucas Gass (lukeg) 2025-04-22 15:54:10 UTC
Created attachment 181295 [details] [review]
Bug 39414: Retain item type selection when editing a booking

To test:
1. Place a booking on an item.
2. Click on edit to open the Edit booking modal.
3. The item type will be de-selected, and the booking dates calendar will be locked until the item type is re-selected.
4. APPLY PATCH
5. Try steps 1 - 3 again, this time the proper item type should be selected and the date field will not be locked.
6. Try creating a new booking, making sure everything still works as excepted.
Comment 3 Martin Renvoize (ashimema) 2025-04-23 14:25:25 UTC
Created attachment 181377 [details] [review]
Bug 39414: Retain item type selection when editing a booking

To test:
1. Place a booking on an item.
2. Click on edit to open the Edit booking modal.
3. The item type will be de-selected, and the booking dates calendar will be locked until the item type is re-selected.
4. APPLY PATCH
5. Try steps 1 - 3 again, this time the proper item type should be selected and the date field will not be locked.
6. Try creating a new booking, making sure everything still works as excepted.

Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 4 Martin Renvoize (ashimema) 2025-04-23 14:26:06 UTC
Going straight for a QA here.. trivial oversight fixed, thanks Lucas for the fix and Kristi for the report.

Passing QA
Comment 5 Katrin Fischer 2025-04-25 06:49:15 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 6 Kristi 2025-04-29 19:06:44 UTC
Any chance of this as a backport to 24.11?