Bug 39517 - Make LDR/6-7 = 'am' be interpreted by MARC21slim2OPACDetail.xsl as 'Book' instead of more generic 'Text'
Summary: Make LDR/6-7 = 'am' be interpreted by MARC21slim2OPACDetail.xsl as 'Book' ins...
Status: In Discussion
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low trivial
Assignee: Janusz Kaczmarek
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-04-01 19:39 UTC by Janusz Kaczmarek
Modified: 2025-04-01 23:16 UTC (History)
1 user (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 39517: Make LDR/6-7 = 'am' be interpreted by MARC21slim2OPACDetail.xsl as 'Book' instead of more generic 'Text' (2.17 KB, patch)
2025-04-01 19:52 UTC, Janusz Kaczmarek
Details | Diff | Splinter Review
Bug 39517: Make LDR/6-7 = 'am' be interpreted by MARC21slim2OPACDetail.xsl as 'Book' instead of more generic 'Text' (2.22 KB, patch)
2025-04-01 20:56 UTC, Roman Dolny
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Janusz Kaczmarek 2025-04-01 19:39:09 UTC
Currently, in OPAC, MARC21slim2OPACDetail.xsl assigns to LDR/6-7 = 'am' a label 'Text' (materialTypeLabel), which is then used in defining variable schemaOrgType and also for display. The variable schemaOrgType would be set to 'Book' if materialTypeLabel was 'Book', but with the current xslt code never will be. Instead schemaOrgType will be set to a generic type CreativeWork for 'am'.

materialTypeLabel is also used for display purposes as the label next to the material type icon (when DisplayOPACiconsXSLT enabled).
Comment 1 Janusz Kaczmarek 2025-04-01 19:52:53 UTC
Created attachment 180229 [details] [review]
Bug 39517: Make LDR/6-7 = 'am' be interpreted by MARC21slim2OPACDetail.xsl as 'Book' instead of more generic 'Text'

Currently, in OPAC, MARC21slim2OPACDetail.xsl assigns to LDR/6-7 =
'am' a label 'Text' (materialTypeLabel), which is then used in
defining variable schemaOrgType and also for display. The variable
schemaOrgType would be set to 'Book' if materialTypeLabel was 'Book',
but with the current xslt code never will be. Instead
schemaOrgType will be set to a generic type CreativeWork
for 'am'.

materialTypeLabel is also used for display purposes as
the label next to the material type icon (when
DisplayOPACiconsXSLT enabled).

Test plan:
==========
1. Make sure that DisplayOPACiconsXSLT is on.
2. In OPAC open any book record (e.g. in standard ktd - sn:1).
3. Note "Material type: [icon] Text" info below author line.
4. Apply the patch ; restart_all
5. Verify that you get "Material type: [icon] Book" info below author
   line.
Comment 2 Roman Dolny 2025-04-01 20:56:20 UTC
Created attachment 180230 [details] [review]
Bug 39517: Make LDR/6-7 = 'am' be interpreted by MARC21slim2OPACDetail.xsl as 'Book' instead of more generic 'Text'

Currently, in OPAC, MARC21slim2OPACDetail.xsl assigns to LDR/6-7 =
'am' a label 'Text' (materialTypeLabel), which is then used in
defining variable schemaOrgType and also for display. The variable
schemaOrgType would be set to 'Book' if materialTypeLabel was 'Book',
but with the current xslt code never will be. Instead
schemaOrgType will be set to a generic type CreativeWork
for 'am'.

materialTypeLabel is also used for display purposes as
the label next to the material type icon (when
DisplayOPACiconsXSLT enabled).

Test plan:
==========
1. Make sure that DisplayOPACiconsXSLT is on.
2. In OPAC open any book record (e.g. in standard ktd - sn:1).
3. Note "Material type: [icon] Text" info below author line.
4. Apply the patch ; restart_all
5. Verify that you get "Material type: [icon] Book" info below author
   line.

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 3 David Cook 2025-04-01 23:16:38 UTC
There's no guarantee that it's a book. It could be an electronic resource, it could be a report, research study, a pamphlet, a thesis, a play, etc. 

--
06 - Type of record
a - Language material
Used for non-manuscript language material. Manuscript language material uses code t.

Includes microforms and electronic resources that are basically textual in nature, whether they are reproductions from print or originally produced.

--
07 - Bibliographic level
m - Monograph/Item
Item either complete in one part (e.g., a single monograph, a single map, a single manuscript, etc.) or intended to be completed, in a finite number of separate parts (e.g., a multivolume monograph, a sound recording with multiple tracks, etc.).