A recent web usability audit has highlighted that when logged in, some of the fields in the 'Your Details' page are identified as required using red text beneath but this is not indicated programmatically. The solution is to add the required tribute to the fields.
Created attachment 180688 [details] [review] Bug 39547: Required Fields Not Conveyed An accessibility audit highlighted that the Personal Details form uses required in red text to indicate when a field is required but this is not also conveyed programmatically for users with screen readers. To test: 1) On Koha's staff site, naviagte to Administration 2) Add surname to PatronSelfModificationMandatoryField 3) On the oPac, navigate to Home > Koha > Your Personal Details 4) Notice that under surname there is red text that reads 'required' 5) Right click and inspect the Surname input 6) Notice that the input field does not have a required attribute 7) Apply the patch 8) Repeat the steps above 9) Notice that on inspect, the required attribute is now present 10) Navigate back to the staff site and to Administration 11) Remove Surname from PatronSelfModificationMandatoryField 12) Navigate back to the oPac Home > Koha > Your Personal Details and refresh 13) Inspect the Surname element and notice that the required attribute is gone 14) The same behaviour should be present for all form elements
Created attachment 180710 [details] [review] Bug 39547: Required Fields Not Conveyed An accessibility audit highlighted that the Personal Details form uses required in red text to indicate when a field is required but this is not also conveyed programmatically for users with screen readers. To test: 1) On Koha's staff site, naviagte to Administration 2) Add surname to PatronSelfModificationMandatoryField 3) On the oPac, navigate to Home > Koha > Your Personal Details 4) Notice that under surname there is red text that reads 'required' 5) Right click and inspect the Surname input 6) Notice that the input field does not have a required attribute 7) Apply the patch 8) Repeat the steps above 9) Notice that on inspect, the required attribute is now present 10) Navigate back to the staff site and to Administration 11) Remove Surname from PatronSelfModificationMandatoryField 12) Navigate back to the oPac Home > Koha > Your Personal Details and refresh 13) Inspect the Surname element and notice that the required attribute is gone 14) The same behaviour should be present for all form elements Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Created attachment 182259 [details] [review] Bug 39547: Required Fields Not Conveyed An accessibility audit highlighted that the Personal Details form uses required in red text to indicate when a field is required but this is not also conveyed programmatically for users with screen readers. To test: 1) On Koha's staff site, naviagte to Administration 2) Add surname to PatronSelfModificationMandatoryField 3) On the oPac, navigate to Home > Koha > Your Personal Details 4) Notice that under surname there is red text that reads 'required' 5) Right click and inspect the Surname input 6) Notice that the input field does not have a required attribute 7) Apply the patch 8) Repeat the steps above 9) Notice that on inspect, the required attribute is now present 10) Navigate back to the staff site and to Administration 11) Remove Surname from PatronSelfModificationMandatoryField 12) Navigate back to the oPac Home > Koha > Your Personal Details and refresh 13) Inspect the Surname element and notice that the required attribute is gone 14) The same behaviour should be present for all form elements Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Passing QA, this is a small but important accessibility improvement which causes no regressions for general users.
Pushed for 25.05! Well done everyone, thank you!