In opac-detail, if a record has a void value for the second indicator for either the field 780 or 785, then the row does not have a span to label it.
Created attachment 180746 [details] [review] Bug 39596: Adding a label when the second indicator of MARC 780/785 is void Test plan: 1. Go to Administration > MARC Bibliographic framework 2. On the right side of the default framework, click on "Actions" > "MARC Structure" 3. Search for field 780 4. Click on "Actions" > "Edit subfields" 5. Click on the "t" tab 6. Check "Editor" under the "Visibility" section 7. Click on "Save Changes" 8. Repeat steps 1 to 7 for field 785$t 9. Have or create a record with a value for 780 and 785 with the first indicator at 0 and the other left empty 10. Go see the record on the OPAC 11. Notice that in Normal View, the value entered for 780 and 785 do not have labels 12. Apply the patch 13. There are now labels
Created attachment 180766 [details] [review] Bug 39596: Adding a label when the second indicator of MARC 780/785 is void Test plan: 1. Go to Administration > MARC Bibliographic framework 2. On the right side of the default framework, click on "Actions" > "MARC Structure" 3. Search for field 780 4. Click on "Actions" > "Edit subfields" 5. Click on the "t" tab 6. Check "Editor" under the "Visibility" section 7. Click on "Save Changes" 8. Repeat steps 1 to 7 for field 785$t 9. Have or create a record with a value for 780 and 785 with the first indicator at 0 and the other left empty 10. Go see the record on the OPAC 11. Notice that in Normal View, the value entered for 780 and 785 do not have labels 12. Apply the patch 13. There are now labels Signed-off-by: Owen Leonard <oleonard@myacpl.org>
This works as advertised but we need a fix for the staff interface too!
Created attachment 180779 [details] [review] Bug 39596: Adding labels in the staff interface Test plan: 1. Go to Administration > MARC Bibliographic framework 2. On the right side of the default framework, click on "Actions" > "MARC Structure" 3. Search for field 780 4. Click on "Actions" > "Edit subfields" 5. Click on the "t" tab 6. Check "Editor" under the "Visibility" section 7. Click on "Save Changes" 8. Repeat steps 1 to 7 for field 785$t 9. Have or create a record with a value for 780 and 785 with the first indicator at 0 and the other left empty 10. Look at the record on the staff interface and the OPAC 11. Notice that in Normal View, the values entered for 780 and 785 do not have labels 12. Apply the patch 13. There are now labels in the staff interface and the OPAC
Thank you for looking at it! I have added a patch to deal with the staff interface. I have updated the test plan to reflect these changes.
Created attachment 180783 [details] [review] Bug 39596: Adding labels in the staff interface Test plan: 1. Go to Administration > MARC Bibliographic framework 2. On the right side of the default framework, click on "Actions" > "MARC Structure" 3. Search for field 780 4. Click on "Actions" > "Edit subfields" 5. Click on the "t" tab 6. Check "Editor" under the "Visibility" section 7. Click on "Save Changes" 8. Repeat steps 1 to 7 for field 785$t 9. Have or create a record with a value for 780 and 785 with the first indicator at 0 and the other left empty 10. Look at the record on the staff interface and the OPAC 11. Notice that in Normal View, the values entered for 780 and 785 do not have labels 12. Apply the patch 13. There are now labels in the staff interface and the OPAC Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 180812 [details] [review] Bug 39596: Adding a label when the second indicator of MARC 780/785 is void Test plan: 1. Go to Administration > MARC Bibliographic framework 2. On the right side of the default framework, click on "Actions" > "MARC Structure" 3. Search for field 780 4. Click on "Actions" > "Edit subfields" 5. Click on the "t" tab 6. Check "Editor" under the "Visibility" section 7. Click on "Save Changes" 8. Repeat steps 1 to 7 for field 785$t 9. Have or create a record with a value for 780 and 785 with the first indicator at 0 and the other left empty 10. Go see the record on the OPAC 11. Notice that in Normal View, the value entered for 780 and 785 do not have labels 12. Apply the patch 13. There are now labels Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 180813 [details] [review] Bug 39596: Adding labels in the staff interface Test plan: 1. Go to Administration > MARC Bibliographic framework 2. On the right side of the default framework, click on "Actions" > "MARC Structure" 3. Search for field 780 4. Click on "Actions" > "Edit subfields" 5. Click on the "t" tab 6. Check "Editor" under the "Visibility" section 7. Click on "Save Changes" 8. Repeat steps 1 to 7 for field 785$t 9. Have or create a record with a value for 780 and 785 with the first indicator at 0 and the other left empty 10. Look at the record on the staff interface and the OPAC 11. Notice that in Normal View, the values entered for 780 and 785 do not have labels 12. Apply the patch 13. There are now labels in the staff interface and the OPAC Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed for 25.05! Well done everyone, thank you!