Bug 39603 - OPAC advanced search display or ITEMTYPECAT is wrong if other authorised values have the same code
Summary: OPAC advanced search display or ITEMTYPECAT is wrong if other authorised val...
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-04-10 15:31 UTC by Lucas Gass (lukeg)
Modified: 2025-04-10 19:02 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 39603: Make sure authorised value category is ITEMTYPECAT (1.73 KB, patch)
2025-04-10 15:48 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 39603: Make sure authorised value category is ITEMTYPECAT (1.78 KB, patch)
2025-04-10 18:47 UTC, Eric Phetteplace
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2025-04-10 15:31:28 UTC
To recreate:

1. Add some AVs for ITEMTYPECAT and set some of your item types to be in that Search category. I made one called OTHER
2. Go to the OPAC advanced search page, the item types should be correctly displaying under ITEMTYPECAT with the correct description from ITEMTYPECAT.
3. Create a new AV called OTHER in a different category like 'ERM_AGREEMENT_CLOSURE_REASON'. Make the description something different like 'Wrong description'. 
4. Now go back to the OPAC advanced search.
4. Notice your OTHER option now reads 'Wrong description'.
Comment 1 Lucas Gass (lukeg) 2025-04-10 15:48:50 UTC
Created attachment 180784 [details] [review]
Bug 39603: Make sure authorised value category is ITEMTYPECAT

To test:
1. Add some AVs for ITEMTYPECAT and set some of your item types to be in that Search category. I made one called OTHER
2. Go to the OPAC advanced search page, the item types should be correctly displaying under ITEMTYPECAT with the correct description from ITEMTYPECAT.
3. Create a new AV called OTHER in a different category like 'ERM_AGREEMENT_CLOSURE_REASON'. Make the description something different like 'Wrong description'.
4. Now go back to the OPAC advanced search.
5. Notice your OTHER option now reads 'Wrong description'.
6. APPLY PATCH and restart_all
7. Try again, the OPAC descriptions should now be correct.
Comment 2 Eric Phetteplace 2025-04-10 18:47:44 UTC
Created attachment 180801 [details] [review]
Bug 39603: Make sure authorised value category is ITEMTYPECAT

To test:
1. Add some AVs for ITEMTYPECAT and set some of your item types to be in that Search category. I made one called OTHER
2. Go to the OPAC advanced search page, the item types should be correctly displaying under ITEMTYPECAT with the correct description from ITEMTYPECAT.
3. Create a new AV called OTHER in a different category like 'ERM_AGREEMENT_CLOSURE_REASON'. Make the description something different like 'Wrong description'.
4. Now go back to the OPAC advanced search.
5. Notice your OTHER option now reads 'Wrong description'.
6. APPLY PATCH and restart_all
7. Try again, the OPAC descriptions should now be correct.

Signed-off-by: Eric Phetteplace <phette23@gmail.com>