Bug 39626 - Display patron name in 'Holds to pull' report using standard template
Summary: Display patron name in 'Holds to pull' report using standard template
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Fridolin Somers
QA Contact: Lucas Gass (lukeg)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-04-14 12:36 UTC by Fridolin Somers
Modified: 2025-06-26 14:40 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00,24.11.07
Circulation function:


Attachments
Bug 39626: Use patron-title.inc in pendingreserves.tt (1.93 KB, patch)
2025-04-14 14:27 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 39626: Use patron-title.inc in pendingreserves.tt (1.93 KB, patch)
2025-04-14 14:30 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 39626: Use patron-title.inc in pendingreserves.tt (1.98 KB, patch)
2025-04-14 19:09 UTC, Roman Dolny
Details | Diff | Splinter Review
Bug 39626: Use patron-title.inc in pendingreserves.tt (2.08 KB, patch)
2025-04-14 19:12 UTC, Emmanuel Bétemps
Details | Diff | Splinter Review
Bug 39626: Use patron-title.inc in pendingreserves.tt (2.13 KB, patch)
2025-04-18 15:05 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2025-04-14 12:36:45 UTC
In "Holds to pull" page, patron column should use patron-title.inc like in other pages.
This allows to use surname first to allow better sorting/finding.
Comment 1 Fridolin Somers 2025-04-14 14:27:50 UTC
Created attachment 180920 [details] [review]
Bug 39626: Use patron-title.inc in pendingreserves.tt

In "Holds to pull" page, patron column should use patron-title.inc like in other pages (like waiting holds).
This allows to use surname first to allow better sorting/finding.

Test plan :
1) Place an hold on some record
2) Go to  Circulation > Holds to pull
3) Check you see in column "First patron" : surname then firstname
Comment 2 Fridolin Somers 2025-04-14 14:30:16 UTC
Created attachment 180921 [details] [review]
Bug 39626: Use patron-title.inc in pendingreserves.tt

In "Holds to pull" page, patron column should use patron-title.inc like in other pages (like waiting holds).
This allows to use surname first to allow better sorting/finding.

Test plan :
1) Place an hold on some record
2) Go to  Circulation > Holds to pull
3) Check you see in column "First patron" : surname then firstname
Comment 3 Fridolin Somers 2025-04-14 14:39:01 UTC
Also allows to display middle name, other name ...
Comment 4 Roman Dolny 2025-04-14 19:09:20 UTC
Created attachment 180928 [details] [review]
Bug 39626: Use patron-title.inc in pendingreserves.tt

In "Holds to pull" page, patron column should use patron-title.inc like in other pages (like waiting holds).
This allows to use surname first to allow better sorting/finding.

Test plan :
1) Place an hold on some record
2) Go to  Circulation > Holds to pull
3) Check you see in column "First patron" : surname then firstname

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>

Test/SO note: it also adds cardnumber at the end.
Comment 5 Emmanuel Bétemps 2025-04-14 19:12:05 UTC
Created attachment 180929 [details] [review]
Bug 39626: Use patron-title.inc in pendingreserves.tt

In "Holds to pull" page, patron column should use patron-title.inc like in other pages (like waiting holds).
This allows to use surname first to allow better sorting/finding.

Test plan :
1) Place an hold on some record
2) Go to  Circulation > Holds to pull
3) Check you see in column "First patron" : surname then firstname

Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com>
Comment 6 Emmanuel Bétemps 2025-04-14 19:17:16 UTC
Hi,

middle and other names are effectively displayed but there's no space between them

Acevedo, Henry
middle(other)
(23529000035676) 


Manu.
Comment 7 Lucas Gass (lukeg) 2025-04-18 15:02:53 UTC
(In reply to Emmanuel Bétemps from comment #6)
> Hi,
> 
> middle and other names are effectively displayed but there's no space
> between them
> 
> Acevedo, Henry
> middle(other)
> (23529000035676) 
> 
> 
> Manu.

This was fixed by Bug 39308.
Comment 8 Lucas Gass (lukeg) 2025-04-18 15:05:53 UTC
Created attachment 181184 [details] [review]
Bug 39626: Use patron-title.inc in pendingreserves.tt

In "Holds to pull" page, patron column should use patron-title.inc like in other pages (like waiting holds).
This allows to use surname first to allow better sorting/finding.

Test plan :
1) Place an hold on some record
2) Go to  Circulation > Holds to pull
3) Check you see in column "First patron" : surname then firstname

Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 9 Katrin Fischer 2025-04-22 06:39:52 UTC
I love these small fixes!
Comment 10 Katrin Fischer 2025-04-22 06:50:54 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 11 Fridolin Somers 2025-06-26 14:40:13 UTC
Pushed to 24.11 for 24.11.07