Bug 39642 - Add SMS number to hold found modals on return.tt
Summary: Add SMS number to hold found modals on return.tt
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Lucas Gass (lukeg)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-04-15 16:55 UTC by Lucas Gass (lukeg)
Modified: 2025-06-27 14:00 UTC (History)
3 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 39642: Add SMS number to holds modals on return.tt (2.30 KB, patch)
2025-04-15 16:58 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 39642: Add SMS number to holds modals on return.tt (2.35 KB, patch)
2025-04-15 19:41 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 39642: Add SMS number to holds modals on return.tt (2.49 KB, patch)
2025-06-27 13:59 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2025-04-15 16:55:05 UTC
There are 2 holds modal ( waiting hold, hold that needs transfer ) that include the 'Hold for:' text. Some would find it hand if the SMSalertnumber was included here.
Comment 1 Lucas Gass (lukeg) 2025-04-15 16:58:20 UTC
Created attachment 180977 [details] [review]
Bug 39642: Add SMS number to holds modals on return.tt

To test:
0. APPLY PACTH
1. Set SMSSendDriver to test.
2. Find a patron record and add the smsalertnumber
3. Place a hold for that patron.
4. Trigger the hold when it is waiting.
5. Notice the SMS number is included in the Hold for: section of the modal.
6. Change branches so the hold will need a transfer.
7. Check it in, and notice the SMS number is again included in the Hold for: section of the modal.
Comment 2 Owen Leonard 2025-04-15 19:41:11 UTC
Created attachment 180994 [details] [review]
Bug 39642: Add SMS number to holds modals on return.tt

To test:
0. APPLY PACTH
1. Set SMSSendDriver to test.
2. Find a patron record and add the smsalertnumber
3. Place a hold for that patron.
4. Trigger the hold when it is waiting.
5. Notice the SMS number is included in the Hold for: section of the
   modal.
6. Change branches so the hold will need a transfer.
7. Check it in, and notice the SMS number is again included in the Hold
   for: section of the modal.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Lucas Gass (lukeg) 2025-06-27 13:59:38 UTC
Created attachment 183605 [details] [review]
Bug 39642: Add SMS number to holds modals on return.tt

To test:
0. APPLY PACTH
1. Set SMSSendDriver to test.
2. Find a patron record and add the smsalertnumber
3. Place a hold for that patron.
4. Trigger the hold when it is waiting.
5. Notice the SMS number is included in the Hold for: section of the
   modal.
6. Change branches so the hold will need a transfer.
7. Check it in, and notice the SMS number is again included in the Hold
   for: section of the modal.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Lucas Gass (lukeg) 2025-06-27 14:00:02 UTC
rebased for current main