When OnSiteCheckoutsForce is set it is possible to on-site checkout an item to a restricted patron. But the due data that is labelled with "Automatic due date:" is not being set. As a result, when such a checkout is performed and you do not set the date manually, the due date will be set as for normal checkout (even if it is marked as on-site checkout).
Created attachment 181212 [details] [review] Bug 39692: With OnSiteCheckoutsForce the due date should be set When OnSiteCheckoutsForce is set it is possible to on-site checkout an item to a restricted patron. But the due data that is labelled with "Automatic due date:" is not being set. As a result, when such a checkout is performed and you do not set the date manually, the due date will be set as for normal checkout (even if it is marked as on-site checkout). Test plan: ========== 1. Enable OnSiteCheckouts and OnSiteCheckoutsForce; manually restrict a patron. 2. Go to checkout page for this patron. You will notice: "On-site checkouts only. Automatic due date:" with an empty input field for the date. Perform the checkout (pick any existing barcode). Note the due date in patron's checkouts. In standard ktd it will be +5 days from today, as for a regular checkuot (cf. Circulation and fine rules) and the checkout will be marked as on-site checkout. 3. Apply the patch ; restart_all. 4. Repeat p. 2 (with another barcode or after checking-in). The date in the date input field should be set to today's date and after performing the checkout the sue date should also be set to the current date.
Created attachment 181213 [details] [review] Bug 39692: With OnSiteCheckoutsForce the due date should be set When OnSiteCheckoutsForce is set it is possible to on-site checkout an item to a restricted patron. But the due data that is labelled with "Automatic due date:" is not being set. As a result, when such a checkout is performed and you do not set the date manually, the due date will be set as for normal checkout (even if it is marked as on-site checkout). Test plan: ========== 1. Enable OnSiteCheckouts and OnSiteCheckoutsForce; manually restrict a patron. 2. Go to checkout page for this patron. You will notice: "On-site checkouts only. Automatic due date:" with an empty input field for the date. Perform the checkout (pick any existing barcode). Note the due date in patron's checkouts. In standard ktd it will be +5 days from today, as for a regular checkuot (cf. Circulation and fine rules) and the checkout will be marked as on-site checkout. 3. Apply the patch ; restart_all. 4. Repeat p. 2 (with another barcode or after checking-in). The date in the date input field should be set to today's date and after performing the checkout the sue date should also be set to the current date. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Created attachment 181653 [details] [review] Bug 39692: With OnSiteCheckoutsForce the due date should be set When OnSiteCheckoutsForce is set it is possible to on-site checkout an item to a restricted patron. But the due data that is labelled with "Automatic due date:" is not being set. As a result, when such a checkout is performed and you do not set the date manually, the due date will be set as for normal checkout (even if it is marked as on-site checkout). Test plan: ========== 1. Enable OnSiteCheckouts and OnSiteCheckoutsForce; manually restrict a patron. 2. Go to checkout page for this patron. You will notice: "On-site checkouts only. Automatic due date:" with an empty input field for the date. Perform the checkout (pick any existing barcode). Note the due date in patron's checkouts. In standard ktd it will be +5 days from today, as for a regular checkuot (cf. Circulation and fine rules) and the checkout will be marked as on-site checkout. 3. Apply the patch ; restart_all. 4. Repeat p. 2 (with another barcode or after checking-in). The date in the date input field should be set to today's date and after performing the checkout the sue date should also be set to the current date. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com>
Yup, that makes no sense to have a default value different from 0 days I think. Patch small and clean. PQA.
Created attachment 181660 [details] [review] Bug 39692: [23.11] With OnSiteCheckoutsForce the due date should be set When OnSiteCheckoutsForce is set it is possible to on-site checkout an item to a restricted patron. But the due data that is labelled with "Automatic due date:" is not being set. As a result, when such a checkout is performed and you do not set the date manually, the due date will be set as for normal checkout (even if it is marked as on-site checkout). Test plan: ========== 1. Enable OnSiteCheckouts and OnSiteCheckoutsForce; manually restrict a patron. 2. Go to checkout page for this patron. You will notice: "On-site checkouts only. Automatic due date:" with an empty input field for the date. Perform the checkout (pick any existing barcode). Note the due date in patron's checkouts. In standard ktd it will be +5 days from today, as for a regular checkuot (cf. Circulation and fine rules) and the checkout will be marked as on-site checkout. 3. Apply the patch ; restart_all. 4. Repeat p. 2 (with another barcode or after checking-in). The date in the date input field should be set to today's date and after performing the checkout the sue date should also be set to the current date. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com>
The 23.11 patch might not be necessary. The code has moved but it is very similar to the old one.
Pushed for 25.05! Well done everyone, thank you!