If a url in a vue module contains query parameters the mapping for the manual fails and redirects to the homepage when 'Help' is clicked To reproduce navigate to the agreements page in ERM and create at least one. On the list page, use the filters so that you have query parameters in the page URL. Click the 'Help' button - you just get the manual home page
Is Documentation the best component for this bug to be in? I'm afraid it's going to get lost among the requests for updates to the Manual. Would it be more relevant to use the Staff interface component?
Created attachment 183437 [details] [review] Bug 39712: Add tests
Created attachment 183438 [details] [review] Bug 39712: Fix links to the manual from VueJS components Query parameters break the manual mappings in vue modules. If a url in a vue module contains query parameters the mapping for the manual fails and redirects to the homepage when 'Help' is clicked To reproduce navigate to the agreements page in ERM and create at least one. On the list page, use the filters so that you have query parameters in the page URL. Click the 'Help' button - you just get the manual home page Test plan: Confirm that the original issue is fixed when this patch is applied.
Created attachment 183439 [details] [review] Bug 39712: Remove extra '/' from the URL
Created attachment 183440 [details] [review] Bug 39712: Remove warnings [WARN] Use of uninitialized value $view in exists at /kohadevbox/koha/Koha/Manual.pm line 346.
Created attachment 183441 [details] [review] Bug 39712: Add POD
(In reply to Aude Charillon from comment #1) > Is Documentation the best component for this bug to be in? I'm afraid it's > going to get lost among the requests for updates to the Manual. Would it be > more relevant to use the Staff interface component? Bug 19817 was using "Documentation", but happy to change if you think "Staff interface" fits better.
Created attachment 183447 [details] [review] Bug 39712: Add tests Signed-off-by: Aude Charillon <aude.charillon@openfifth.co.uk>
Created attachment 183448 [details] [review] Bug 39712: Fix links to the manual from VueJS components Query parameters break the manual mappings in vue modules. If a url in a vue module contains query parameters the mapping for the manual fails and redirects to the homepage when 'Help' is clicked To reproduce navigate to the agreements page in ERM and create at least one. On the list page, use the filters so that you have query parameters in the page URL. Click the 'Help' button - you just get the manual home page Test plan: Confirm that the original issue is fixed when this patch is applied. Signed-off-by: Aude Charillon <aude.charillon@openfifth.co.uk>
Created attachment 183449 [details] [review] Bug 39712: Remove extra '/' from the URL Signed-off-by: Aude Charillon <aude.charillon@openfifth.co.uk>
Created attachment 183450 [details] [review] Bug 39712: Remove warnings [WARN] Use of uninitialized value $view in exists at /kohadevbox/koha/Koha/Manual.pm line 346. Signed-off-by: Aude Charillon <aude.charillon@openfifth.co.uk>
Created attachment 183451 [details] [review] Bug 39712: Add POD Signed-off-by: Aude Charillon <aude.charillon@openfifth.co.uk>
Fixes the issue as originally described - signing off :-) (Hoping I've done that correctly with the number of patches!)