Bug 39712 - Query parameters break the manual mappings in vue modules
Summary: Query parameters break the manual mappings in vue modules
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Nick Clemens (kidclamp)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-04-23 15:25 UTC by Matt Blenkinsop
Modified: 2025-08-01 19:24 UTC (History)
5 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00
Circulation function:


Attachments
Bug 39712: Add tests (2.31 KB, patch)
2025-06-24 10:41 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 39712: Fix links to the manual from VueJS components (1.38 KB, patch)
2025-06-24 10:41 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 39712: Remove extra '/' from the URL (834 bytes, patch)
2025-06-24 10:41 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 39712: Remove warnings (1.05 KB, patch)
2025-06-24 10:41 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 39712: Add POD (2.19 KB, patch)
2025-06-24 10:41 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 39712: Add tests (2.37 KB, patch)
2025-06-24 12:26 UTC, OpenFifth Sandboxes
Details | Diff | Splinter Review
Bug 39712: Fix links to the manual from VueJS components (1.44 KB, patch)
2025-06-24 12:26 UTC, OpenFifth Sandboxes
Details | Diff | Splinter Review
Bug 39712: Remove extra '/' from the URL (895 bytes, patch)
2025-06-24 12:26 UTC, OpenFifth Sandboxes
Details | Diff | Splinter Review
Bug 39712: Remove warnings (1.11 KB, patch)
2025-06-24 12:26 UTC, OpenFifth Sandboxes
Details | Diff | Splinter Review
Bug 39712: Add POD (2.25 KB, patch)
2025-06-24 12:26 UTC, OpenFifth Sandboxes
Details | Diff | Splinter Review
Bug 39712: Add tests (2.43 KB, patch)
2025-08-01 11:21 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 39712: Fix links to the manual from VueJS components (1.50 KB, patch)
2025-08-01 11:21 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 39712: Remove extra '/' from the URL (953 bytes, patch)
2025-08-01 11:21 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 39712: Remove warnings (1.17 KB, patch)
2025-08-01 11:21 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 39712: Add POD (2.30 KB, patch)
2025-08-01 11:21 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Blenkinsop 2025-04-23 15:25:28 UTC
If a url in a vue module contains query parameters the mapping for the manual fails and redirects to the homepage when 'Help' is clicked

To reproduce navigate to the agreements page in ERM and create at least one. On the list page, use the filters so that you have query parameters in the page URL. Click the 'Help' button - you just get the manual home page
Comment 1 Aude Charillon 2025-06-20 12:48:03 UTC
Is Documentation the best component for this bug to be in? I'm afraid it's going to get lost among the requests for updates to the Manual. Would it be more relevant to use the Staff interface component?
Comment 2 Jonathan Druart 2025-06-24 10:41:05 UTC
Created attachment 183437 [details] [review]
Bug 39712: Add tests
Comment 3 Jonathan Druart 2025-06-24 10:41:07 UTC
Created attachment 183438 [details] [review]
Bug 39712: Fix links to the manual from VueJS components

Query parameters break the manual mappings in vue modules.

If a url in a vue module contains query parameters the mapping for the manual fails and redirects to the homepage when 'Help' is clicked

To reproduce navigate to the agreements page in ERM and create at least one. On the list page, use the filters so that you have query parameters in the page URL. Click the 'Help' button - you just get the manual home page

Test plan:
Confirm that the original issue is fixed when this patch is applied.
Comment 4 Jonathan Druart 2025-06-24 10:41:09 UTC
Created attachment 183439 [details] [review]
Bug 39712: Remove extra '/' from the URL
Comment 5 Jonathan Druart 2025-06-24 10:41:11 UTC
Created attachment 183440 [details] [review]
Bug 39712: Remove warnings

[WARN] Use of uninitialized value $view in exists at /kohadevbox/koha/Koha/Manual.pm line 346.
Comment 6 Jonathan Druart 2025-06-24 10:41:13 UTC
Created attachment 183441 [details] [review]
Bug 39712: Add POD
Comment 7 Jonathan Druart 2025-06-24 10:43:00 UTC
(In reply to Aude Charillon from comment #1)
> Is Documentation the best component for this bug to be in? I'm afraid it's
> going to get lost among the requests for updates to the Manual. Would it be
> more relevant to use the Staff interface component?

Bug 19817 was using "Documentation", but happy to change if you think "Staff interface" fits better.
Comment 8 OpenFifth Sandboxes 2025-06-24 12:26:37 UTC
Created attachment 183447 [details] [review]
Bug 39712: Add tests

Signed-off-by: Aude Charillon <aude.charillon@openfifth.co.uk>
Comment 9 OpenFifth Sandboxes 2025-06-24 12:26:39 UTC
Created attachment 183448 [details] [review]
Bug 39712: Fix links to the manual from VueJS components

Query parameters break the manual mappings in vue modules.

If a url in a vue module contains query parameters the mapping for the manual fails and redirects to the homepage when 'Help' is clicked

To reproduce navigate to the agreements page in ERM and create at least one. On the list page, use the filters so that you have query parameters in the page URL. Click the 'Help' button - you just get the manual home page

Test plan:
Confirm that the original issue is fixed when this patch is applied.

Signed-off-by: Aude Charillon <aude.charillon@openfifth.co.uk>
Comment 10 OpenFifth Sandboxes 2025-06-24 12:26:41 UTC
Created attachment 183449 [details] [review]
Bug 39712: Remove extra '/' from the URL

Signed-off-by: Aude Charillon <aude.charillon@openfifth.co.uk>
Comment 11 OpenFifth Sandboxes 2025-06-24 12:26:43 UTC
Created attachment 183450 [details] [review]
Bug 39712: Remove warnings

[WARN] Use of uninitialized value $view in exists at /kohadevbox/koha/Koha/Manual.pm line 346.

Signed-off-by: Aude Charillon <aude.charillon@openfifth.co.uk>
Comment 12 OpenFifth Sandboxes 2025-06-24 12:26:45 UTC
Created attachment 183451 [details] [review]
Bug 39712: Add POD

Signed-off-by: Aude Charillon <aude.charillon@openfifth.co.uk>
Comment 13 Aude Charillon 2025-06-24 12:28:16 UTC
Fixes the issue as originally described - signing off :-)
(Hoping I've done that correctly with the number of patches!)
Comment 14 Nick Clemens (kidclamp) 2025-08-01 11:21:14 UTC
Created attachment 184983 [details] [review]
Bug 39712: Add tests

Signed-off-by: Aude Charillon <aude.charillon@openfifth.co.uk>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 15 Nick Clemens (kidclamp) 2025-08-01 11:21:17 UTC
Created attachment 184984 [details] [review]
Bug 39712: Fix links to the manual from VueJS components

Query parameters break the manual mappings in vue modules.

If a url in a vue module contains query parameters the mapping for the manual fails and redirects to the homepage when 'Help' is clicked

To reproduce navigate to the agreements page in ERM and create at least one. On the list page, use the filters so that you have query parameters in the page URL. Click the 'Help' button - you just get the manual home page

Test plan:
Confirm that the original issue is fixed when this patch is applied.

Signed-off-by: Aude Charillon <aude.charillon@openfifth.co.uk>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 16 Nick Clemens (kidclamp) 2025-08-01 11:21:20 UTC
Created attachment 184985 [details] [review]
Bug 39712: Remove extra '/' from the URL

Signed-off-by: Aude Charillon <aude.charillon@openfifth.co.uk>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 17 Nick Clemens (kidclamp) 2025-08-01 11:21:22 UTC
Created attachment 184986 [details] [review]
Bug 39712: Remove warnings

[WARN] Use of uninitialized value $view in exists at /kohadevbox/koha/Koha/Manual.pm line 346.

Signed-off-by: Aude Charillon <aude.charillon@openfifth.co.uk>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 18 Nick Clemens (kidclamp) 2025-08-01 11:21:25 UTC
Created attachment 184987 [details] [review]
Bug 39712: Add POD

Signed-off-by: Aude Charillon <aude.charillon@openfifth.co.uk>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 19 Lucas Gass (lukeg) 2025-08-01 19:24:41 UTC
Nice work everyone!

Pushed to main for 25.11