Created attachment 181399 [details] The little loading wheel System preference ExportCircHistory - when I have that set to Don't Show, the menu item for Export still appears in the Checkouts tab of the patron account. I can even click on Export and choose and option, but then it there is a little loading wheel animation but it never goes anywhere. It seems that the "Don't Show" isn't doing what it was perhaps designed to do.
This is an issue for us as well. Even in the configure option, you cannot hide the Export column. So worse than just the column showing when it shouldn't, the Export option doesn't work anymore.
Created attachment 186949 [details] [review] Bug 39719: Added check for ExportCircHistory 1. Apply the patch and restart_all 2. Go to Administration → System preferences -> search for ExportCircHistory. Set it to Don't Show 3. View a patron's current checkouts tab. The Export option should not appear. 4. Set ExportCircHistory to 'Show'. The Export option should reappear. 5. Confirm that the Export button remains visible, no matter the option for ExportCircHistory in other locations such as the holdings table. 6. Sign off and have an amazing day! :D
I am not sure this syspref is intended to control the "standard" export feature available for every Koha table. ExportCircHistory was made to remove this line under the table : "Export checkouts using format: MARC / CSV with items Export items bundle contents Don't export fields: " Note that "ExportCircHistory" is a wrong name for this syspref, as indicated by Owen Leonard on this bug: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40623 I believe this abilty to export the checkout in MARC format (it seems weird) was added to suit the needs of some french libraries.