Bug 39735 - Typo in system preference call 'OPACFineNoRenewalsIncludeCredit'
Summary: Typo in system preference call 'OPACFineNoRenewalsIncludeCredit'
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Fridolin Somers
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 23293
Blocks: 39720
  Show dependency treegraph
 
Reported: 2025-04-24 09:35 UTC by Fridolin Somers
Modified: 2025-05-07 12:31 UTC (History)
0 users

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39735: Fix typo in system preference call 'OPACFineNoRenewalsIncludeCredit' (4.47 KB, patch)
2025-04-24 09:44 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 39735: Fix typo in system preference call 'OPACFineNoRenewalsIncludeCredit' (4.52 KB, patch)
2025-04-24 19:31 UTC, Roman Dolny
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2025-04-24 09:35:18 UTC
Typo in system preference call 'OPACFineNoRenewalsIncludeCredit'
=> 'OPACFineNoRenewalsIncludeCredits'
Comment 1 Fridolin Somers 2025-04-24 09:36:57 UTC
 > git grep OPACFineNoRenewalsIncludeCredit | grep -v OPACFineNoRenewalsIncludeCredits
C4/Circulation.pm:            C4::Context->preference("OPACFineNoRenewalsIncludeCredit")
opac/opac-user.pl:    C4::Context->preference("OPACFineNoRenewalsIncludeCredit")
t/db_dependent/Circulation.t:    subtest "auto_too_much_oweing | OPACFineNoRenewalsBlockAutoRenew & OPACFineNoRenewalsIncludeCredit" => sub {
t/db_dependent/Circulation.t:        C4::Context->set_preference( 'OPACFineNoRenewalsIncludeCredit',  '1' );
t/db_dependent/Circulation.t:            'Can auto renew, OPACFineNoRenewals=10, OPACFineNoRenewalsIncludeCredit=1, patron has 15 debt, 5 credit'
t/db_dependent/Circulation.t:        C4::Context->set_preference( 'OPACFineNoRenewalsIncludeCredit', '0' );
t/db_dependent/Circulation.t:            'Cannot auto renew, OPACFineNoRenewals=10, OPACFineNoRenewalsIncludeCredit=1, patron has 15 debt, 5 credit'
t/db_dependent/Circulation.t:        C4::Context->set_preference( 'OPACFineNoRenewalsIncludeCredit', '1' );
Comment 2 Fridolin Somers 2025-04-24 09:44:41 UTC
Created attachment 181420 [details] [review]
Bug 39735: Fix typo in system preference call 'OPACFineNoRenewalsIncludeCredit'

Typo in system preference call 'OPACFineNoRenewalsIncludeCredit'
=> 'OPACFineNoRenewalsIncludeCredits'

Test plan :
Run : prove t/db_dependent/Circulation.t
Run test plan of Bug 23293
Comment 3 Roman Dolny 2025-04-24 19:31:31 UTC
Created attachment 181468 [details] [review]
Bug 39735: Fix typo in system preference call 'OPACFineNoRenewalsIncludeCredit'

Typo in system preference call 'OPACFineNoRenewalsIncludeCredit'
=> 'OPACFineNoRenewalsIncludeCredits'

Test plan :
Run : prove t/db_dependent/Circulation.t
Run test plan of Bug 23293

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 4 Katrin Fischer 2025-05-07 12:31:42 UTC
Pushed for 25.05!

Well done everyone, thank you!