To recreate: 1 - Enable UseBranchTransferLimits based on 'Collection code' 2 - Disable transfers for FIC from: CPL -> FFL CPL -> IPT FFL -> CPL FFL -> IPT IPT -> CPL IPT -> FFL 3 - Set library to IPT 4 - Checkin an FFL item 5 - It generates a transfer home 6 - Set library to CPL 7 - Check the item in 8 - 500 error, and in logs: ==> /var/log/koha/kohadev/plack-error.log <== Exception 'Koha::Exceptions::Item::Transfer::Limit' thrown 'Transfer not allowed'
Created attachment 181547 [details] [review] Bug 39750: Ignore limits when updating WrongTransfer This patch ignores limits when updating a wrong transfer to ensure we can return a book home when checked in at the wrong branch To test: 1 - Enable UseBranchTransferLimits based on 'Collection code' 2 - Disable transfers for FIC from: CPL -> FFL CPL -> IPT FFL -> CPL FFL -> IPT IPT -> CPL IPT -> FFL 3 - Set library to IPT 4 - Checkin an FFL item 5 - It generates a transfer home 6 - Set library to CPL 7 - Check the item in 8 - 500 error, and in logs: ==> /var/log/koha/kohadev/plack-error.log <== Exception 'Koha::Exceptions::Item::Transfer::Limit' thrown 'Transfer not allowed' 9 - Apply patch, restart all 10 - Check item in again 11 - Success! Transfer updated
Created attachment 181557 [details] [review] Bug 39750: Ignore limits when updating WrongTransfer This patch ignores limits when updating a wrong transfer to ensure we can return a book home when checked in at the wrong branch To test: 1 - Enable UseBranchTransferLimits based on 'Collection code' 2 - Disable transfers for FIC from: CPL -> FFL CPL -> IPT FFL -> CPL FFL -> IPT IPT -> CPL IPT -> FFL 3 - Set library to IPT 4 - Checkin an FFL item 5 - It generates a transfer home 6 - Set library to CPL 7 - Check the item in 8 - 500 error, and in logs: ==> /var/log/koha/kohadev/plack-error.log <== Exception 'Koha::Exceptions::Item::Transfer::Limit' thrown 'Transfer not allowed' 9 - Apply patch, restart all 10 - Check item in again 11 - Success! Transfer updated Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Created attachment 181575 [details] [review] Bug 39750: Ignore limits when updating WrongTransfer This patch ignores limits when updating a wrong transfer to ensure we can return a book home when checked in at the wrong branch To test: 1 - Enable UseBranchTransferLimits based on 'Collection code' 2 - Disable transfers for FIC from: CPL -> FFL CPL -> IPT FFL -> CPL FFL -> IPT IPT -> CPL IPT -> FFL 3 - Set library to IPT 4 - Checkin an FFL item 5 - It generates a transfer home 6 - Set library to CPL 7 - Check the item in 8 - 500 error, and in logs: ==> /var/log/koha/kohadev/plack-error.log <== Exception 'Koha::Exceptions::Item::Transfer::Limit' thrown 'Transfer not allowed' 9 - Apply patch, restart all 10 - Check item in again 11 - Success! Transfer updated Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Pushed for 25.05! Well done everyone, thank you!