Bug 39754 - Cannot scroll EANs when clicking 'Create EDIFACT order' in a basket
Summary: Cannot scroll EANs when clicking 'Create EDIFACT order' in a basket
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Martin Renvoize (ashimema)
QA Contact: Paul Derscheid
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-04-26 15:11 UTC by Nick Clemens (kidclamp)
Modified: 2025-05-22 13:25 UTC (History)
3 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39754: Enable fixed height and overflow on EDIFACT dropdown (1.61 KB, patch)
2025-04-28 08:59 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 39754: Enable fixed height and overflow on EDIFACT dropdown (1.67 KB, patch)
2025-04-28 11:26 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 39754: Enable fixed height and overflow on EDIFACT dropdown (1.67 KB, patch)
2025-05-13 18:50 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 39754: Enable fixed height and overflow on EDIFACT dropdown (1.72 KB, patch)
2025-05-20 14:03 UTC, Paul Derscheid
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2025-04-26 15:11:17 UTC
To recreate:
1 - Enable EDI:
    http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=acquisitions#acquisitions_EDIFACT
2 - Add an edi account:
    http://localhost:8081/cgi-bin/koha/admin/edi_accounts.pl
3 - Add a large number (30-50) of EAN accounts:
    http://localhost:8081/cgi-bin/koha/admin/edi_ean_accounts.pl
    I did this by spamming SQL:
    INSERT INTO edifact_ean (description,ean) VALUES (CONCAT("Test ",rand(400)),rand(1000));
4 - Find a basket for the vendor you attached the EDI account to
5 - Add an order
6 - Click 'Create EDIFACT order' in the basket
7 - You get a dropdown that cannot be scrolled
Comment 1 Martin Renvoize (ashimema) 2025-04-28 08:59:23 UTC
Created attachment 181578 [details] [review]
Bug 39754: Enable fixed height and overflow on EDIFACT dropdown

This patch updates the 'Create EDIFACT order' menu dropdown for cases
where multiple EANs are available for the library.

We set the dropdown to a max-height of 75% of the window height and then
we enable y scrolling and hide the x scrollbar.
Comment 2 Martin Renvoize (ashimema) 2025-04-28 09:01:20 UTC
We could perhaps improve this by adding an additional 'scrollable-dropdown' class to our stylesheets that set's the dropdown height and applies the two utility classes.  But I'm not sure how often this is an problem so how much we want to do this in the upstream CSS
Comment 3 Nick Clemens (kidclamp) 2025-04-28 11:26:33 UTC
Created attachment 181591 [details] [review]
Bug 39754: Enable fixed height and overflow on EDIFACT dropdown

This patch updates the 'Create EDIFACT order' menu dropdown for cases
where multiple EANs are available for the library.

We set the dropdown to a max-height of 75% of the window height and then
we enable y scrolling and hide the x scrollbar.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Lucas Gass (lukeg) 2025-04-29 15:50:24 UTC
I think there is a typo in the class name `overflow-y-autoi`.
Comment 5 Martin Renvoize (ashimema) 2025-05-13 18:50:07 UTC
Created attachment 182400 [details] [review]
Bug 39754: Enable fixed height and overflow on EDIFACT dropdown

This patch updates the 'Create EDIFACT order' menu dropdown for cases
where multiple EANs are available for the library.

We set the dropdown to a max-height of 75% of the window height and then
we enable y scrolling and hide the x scrollbar.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 6 Paul Derscheid 2025-05-20 14:03:47 UTC
Created attachment 182677 [details] [review]
Bug 39754: Enable fixed height and overflow on EDIFACT dropdown

This patch updates the 'Create EDIFACT order' menu dropdown for cases
where multiple EANs are available for the library.

We set the dropdown to a max-height of 75% of the window height and then
we enable y scrolling and hide the x scrollbar.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 7 Katrin Fischer 2025-05-22 13:25:48 UTC
Pushed for 25.05!

Well done everyone, thank you!