To recreate: 1 - Enable EDI: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=acquisitions#acquisitions_EDIFACT 2 - Add an edi account: http://localhost:8081/cgi-bin/koha/admin/edi_accounts.pl 3 - Add a large number (30-50) of EAN accounts: http://localhost:8081/cgi-bin/koha/admin/edi_ean_accounts.pl I did this by spamming SQL: INSERT INTO edifact_ean (description,ean) VALUES (CONCAT("Test ",rand(400)),rand(1000)); 4 - Find a basket for the vendor you attached the EDI account to 5 - Add an order 6 - Click 'Create EDIFACT order' in the basket 7 - You get a dropdown that cannot be scrolled
Created attachment 181578 [details] [review] Bug 39754: Enable fixed height and overflow on EDIFACT dropdown This patch updates the 'Create EDIFACT order' menu dropdown for cases where multiple EANs are available for the library. We set the dropdown to a max-height of 75% of the window height and then we enable y scrolling and hide the x scrollbar.
We could perhaps improve this by adding an additional 'scrollable-dropdown' class to our stylesheets that set's the dropdown height and applies the two utility classes. But I'm not sure how often this is an problem so how much we want to do this in the upstream CSS
Created attachment 181591 [details] [review] Bug 39754: Enable fixed height and overflow on EDIFACT dropdown This patch updates the 'Create EDIFACT order' menu dropdown for cases where multiple EANs are available for the library. We set the dropdown to a max-height of 75% of the window height and then we enable y scrolling and hide the x scrollbar. Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
I think there is a typo in the class name `overflow-y-autoi`.
Created attachment 182400 [details] [review] Bug 39754: Enable fixed height and overflow on EDIFACT dropdown This patch updates the 'Create EDIFACT order' menu dropdown for cases where multiple EANs are available for the library. We set the dropdown to a max-height of 75% of the window height and then we enable y scrolling and hide the x scrollbar. Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 182677 [details] [review] Bug 39754: Enable fixed height and overflow on EDIFACT dropdown This patch updates the 'Create EDIFACT order' menu dropdown for cases where multiple EANs are available for the library. We set the dropdown to a max-height of 75% of the window height and then we enable y scrolling and hide the x scrollbar. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Pushed for 25.05! Well done everyone, thank you!