In biblio page, subscription sorting is broken again :)
Can you explain a bit more?
Created attachment 181577 [details] [review] Bug 39757: Fix default sort order Test plan: 1 - Have a notice with mutliple serials received on different days, notice they are not sorted by date by default 2 - Have a non-serial notice, notice there is no sort order 3 - Apply patch 4 - Go to the serials notice -> it is well ordered (by acquisition date) 5 - Go to the non-serial notice -> is is sorted by accession date Note: I picked accession date because it is how it works in Koha::Item::search_ordered which is not used anymore for this purpose.
Is this related to this FIXME in Koha/REST/V1/Biblios.pm + # FIXME We need to order_by serial.publisheddate if we have _order_by=+me.serial_issue_number Isn't it something we need server-side instead?
(In reply to Jonathan Druart from comment #3) > Is this related to this FIXME in > Koha/REST/V1/Biblios.pm > + # FIXME We need to order_by serial.publisheddate if we have > _order_by=+me.serial_issue_number > > Isn't it something we need server-side instead? Hum... I'd rather say both ? If we only fix on server side, the information of the sort order won't be displayed to the user, will it ? I'd rather say the API stays simple and stupid and we sort as we want on client side, but this comment is there, you're right.
What about serialid.publisheddate vs dateaccessioned? I don't remember exactly but I would look at how it was done before bug 33568. I cannot right now, but I can have another look later. I would also ask Katrin and/or Nick.
Idk if this helps, but in Koha::Items::search_ordered, it is : serialid.publisheddate > me.enumchron for serials and homebranch.branchname > me.enumchron > me.dateaccessioned (desc) for others