Bug 39600 added global inclusion of datatables.min.css to the OPAC's doc-head-close.inc after our opac.css, meaning it overrides our CSS instead of vice versa. Previously datatables.min.css wasn't included globally in the OPAC because so few tables use DataTables. The styling we need is in _tables.scss. I'm not sure what CSS was missing when 39600 was implemented, but we need to either add the required CSS to _tables.scss or rework our implementation of DataTables CSS.
(In reply to Owen Leonard from comment #0) > Previously datatables.min.css wasn't included globally in the OPAC because > so few tables use DataTables. The styling we need is in _tables.scss. To expand on that a little: Because we needed to style so few DataTables controls it was easier to add a little bit of custom CSS to ours instead of needing to add a lot of CSS in order to customize *and* override the default DataTables styling.
Could you provide a patch? Trying to get the lose ends in order that seem to pop up everywhere...
Created attachment 181647 [details] [review] Bug 39761: OPAC DataTables responsive table controls style broken by Bug 39600 This patch copies and adapts some CSS from the default DataTables CSS in order to add to the OPAC the required styles for new features added by the updated ILL request page: Paging, table information, and the "Processing" message shown while the table loads. To test, apply the patch and rebuild the OPAC CSS. You should have ILL enabled and configured. - Log in to the OPAC as a user who has submitted multiple ILL requests. - From the user summary page, click "Interlibrary loan requests" in the left-hand sidebar. - The table of ILL requests should look correct with legible information and controls. - All the DataTable features should work: Paging, showing different numbers of entries per page, sorting. - Go to the user summary page and confirm that the tables on that page still display correctly: Checkouts, overdues, holds, etc. Sponsored-by: Athens County Public Libraries
Created attachment 181659 [details] [review] Bug 39761: OPAC DataTables responsive table controls style broken by Bug 39600 This patch copies and adapts some CSS from the default DataTables CSS in order to add to the OPAC the required styles for new features added by the updated ILL request page: Paging, table information, and the "Processing" message shown while the table loads. To test, apply the patch and rebuild the OPAC CSS. You should have ILL enabled and configured. - Log in to the OPAC as a user who has submitted multiple ILL requests. - From the user summary page, click "Interlibrary loan requests" in the left-hand sidebar. - The table of ILL requests should look correct with legible information and controls. - All the DataTable features should work: Paging, showing different numbers of entries per page, sorting. - Go to the user summary page and confirm that the tables on that page still display correctly: Checkouts, overdues, holds, etc. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com>
Created attachment 181662 [details] [review] Bug 39761: OPAC DataTables responsive table controls style broken by Bug 39600 This patch copies and adapts some CSS from the default DataTables CSS in order to add to the OPAC the required styles for new features added by the updated ILL request page: Paging, table information, and the "Processing" message shown while the table loads. To test, apply the patch and rebuild the OPAC CSS. You should have ILL enabled and configured. - Log in to the OPAC as a user who has submitted multiple ILL requests. - From the user summary page, click "Interlibrary loan requests" in the left-hand sidebar. - The table of ILL requests should look correct with legible information and controls. - All the DataTable features should work: Paging, showing different numbers of entries per page, sorting. - Go to the user summary page and confirm that the tables on that page still display correctly: Checkouts, overdues, holds, etc. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed for 25.05! Well done everyone, thank you!
Depends on Bug 39762 not in 24.11.x