To recreate: 1. In K-T-D set up POS module with a cash register and configure an item for sale. 2. Attempt to add the configured item for purchase. The console log will show: "Uncaught TypeError: table.row is undefined"
Created attachment 181682 [details] [review] Bug 39779: Updated table type To test: 1. In K-T-D set up POS module with a cash register and configure an item for sale. 2. Attempt to add the configured item for purchase. The console log will show: "Uncaught TypeError: table.row is undefined" 3. Apply the patch 4. Refresh the page. 5. Repeat step 2. You are now able to add the configured item for purchase. You can also remove it or go through with the full transaction. 6. Sign off and have an incredible day! :D
Created attachment 181686 [details] [review] Bug 39779: Updated table type To test: 1. In K-T-D set up POS module with a cash register and configure an item for sale. 2. Attempt to add the configured item for purchase. The console log will show: "Uncaught TypeError: table.row is undefined" 3. Apply the patch 4. Refresh the page. 5. Repeat step 2. You are now able to add the configured item for purchase. You can also remove it or go through with the full transaction. 6. Sign off and have an incredible day! :D Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Created attachment 181870 [details] [review] Bug 39779: Updated table type To test: 1. In K-T-D set up POS module with a cash register and configure an item for sale. 2. Attempt to add the configured item for purchase. The console log will show: "Uncaught TypeError: table.row is undefined" 3. Apply the patch 4. Refresh the page. 5. Repeat step 2. You are now able to add the configured item for purchase. You can also remove it or go through with the full transaction. 6. Sign off and have an incredible day! :D Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Created attachment 181871 [details] [review] Bug 39779: (QA follow-up) Undo revert and instead call .api() This patch leaves Laura's patch intact for the record, but effectively reverts it's reversion of bug 38255 in which all ajax DataTables were converted to a standard kohaTable instantiation structure. We need a DataTable() api in subsequent uses of the table and not the jQuery object that kohaTable returns so I update all calls to saleDataTable to sale_kohaTable.api() which returns us the DataTable() api instance from the dataTable jQuery object. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Pushed for 25.05! Well done everyone, thank you!