To reproduce: 1. Visit http://localhost:8081/cgi-bin/koha/opac-memberentry.pl or your test OPAC self registration page. 2. Under Identity scroll down until you see four radio buttons used to choose a gender. Note that there is no label next to the buttons. 3. Apply the patch. 4. The label “Gender” is now visible next to the radio buttons. 5. Sign off and have an amazing day! :D
Created attachment 181688 [details] [review] Bug 39782: Added gender label to patron registration form radio buttons To reproduce: 1. Visit http://localhost:8081/cgi-bin/koha/opac-memberentry.pl or your test OPAC self registration page. 2. Under Identity scroll down until you see four radio buttons used to choose a gender. Note that there is no label next to the buttons. 3. Apply the patch. 4. The label “Gender” is now visible next to the radio buttons. 5. Sign off and have an amazing day! :D
The second reproduce should say "To test"...
Created attachment 181691 [details] [review] Bug 39782: Add gender label to patron registration form radio buttons This fixes the patron registration form in the staff interface. There is no "Gender" label before the radio buttons. Test plan: 1. Go to Patrons > +New patron > [Select any patron type] (http://localhost:8081/cgi-bin/koha/opac-memberentry.pl). 2. In the patron identity section you will see four radio buttons used to choose a gender. Note that there is no label next to the buttons. 3. Apply the patch and refresh the page.. 4. The label "Gender" is now visible next to the radio buttons. 5. Sign off and have an amazing day! :D Signed-off-by: David Nind <david@davidnind.com>
I've amended the commit message (see the commit message guidelines https://wiki.koha-community.org/wiki/Commit_messages) I've also linked it to the bug that fixes the same issue for the OPAC.
Fine for me, not blocking but would you have time to also align it with the rest of the fields ? It is way better but still a bit weird.
(In reply to Baptiste Wojtkowski (bwoj) from comment #5) > Fine for me, not blocking but would you have time to also align it with the > rest of the fields ? It is way better but still a bit weird. I think this may be a general style, as other radio button groups are shown the same way (for example, the "Allow auto-renewal of items" yes/no selection). It uses the class="radio", and has padding-left of 7.5 em (I originally thought it was centred). It is used in a lot of places, not just the patron entry form. For that reason, I think it is outside the scope of this bug - we should create a separate bug for it. If you agree, I'll create the bug.
I agree that the styling is outside the scope of this bug and can be opened as a new bug.
(In reply to Baptiste Wojtkowski (bwoj) from comment #5) > Fine for me, not blocking but would you have time to also align it with the > rest of the fields ? It is way better but still a bit weird. My hope is that my work on converting forms to use a grid layout is going to make this kind of display better. See Bug 39483.
The alignment could be a little nicer, but I believe we can fix later or with Owen's grid work.
Created attachment 181846 [details] [review] Bug 39782: Add gender label to patron registration form radio buttons This fixes the patron registration form in the staff interface. There is no "Gender" label before the radio buttons. Test plan: 1. Go to Patrons > +New patron > [Select any patron type] (http://localhost:8081/cgi-bin/koha/opac-memberentry.pl). 2. In the patron identity section you will see four radio buttons used to choose a gender. Note that there is no label next to the buttons. 3. Apply the patch and refresh the page.. 4. The label "Gender" is now visible next to the radio buttons. 5. Sign off and have an amazing day! :D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com>