Bug 39782 - Staff interface patron registration form - field label missing for gender selection
Summary: Staff interface patron registration form - field label missing for gender sel...
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Laura Escamilla
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-04-29 20:31 UTC by Laura Escamilla
Modified: 2025-05-02 07:26 UTC (History)
5 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the patron registration form in the staff interface. It adds a label ("Gender") before the gender selection options in the patron identity section.
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39782: Added gender label to patron registration form radio buttons (1.85 KB, patch)
2025-04-29 20:33 UTC, Laura Escamilla
Details | Diff | Splinter Review
Bug 39782: Add gender label to patron registration form radio buttons (1.96 KB, patch)
2025-04-30 02:50 UTC, David Nind
Details | Diff | Splinter Review
Bug 39782: Add gender label to patron registration form radio buttons (2.02 KB, patch)
2025-05-02 07:26 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Laura Escamilla 2025-04-29 20:31:26 UTC
To reproduce:
1. Visit http://localhost:8081/cgi-bin/koha/opac-memberentry.pl  or your test OPAC self registration page. 
2. Under Identity scroll down until you see four radio buttons used to choose a gender. Note that there is no label next to the buttons. 
3. Apply the patch. 
4. The label “Gender” is now visible next to the radio buttons. 
5. Sign off and have an amazing day! :D
Comment 1 Laura Escamilla 2025-04-29 20:33:59 UTC
Created attachment 181688 [details] [review]
Bug 39782: Added gender label to patron registration form radio buttons

To reproduce:
1. Visit http://localhost:8081/cgi-bin/koha/opac-memberentry.pl  or your test OPAC self registration page.
2. Under Identity scroll down until you see four radio buttons used to choose a gender. Note that there is no label next to the buttons.
3. Apply the patch.
4. The label “Gender” is now visible next to the radio buttons.
5. Sign off and have an amazing day! :D
Comment 2 Laura Escamilla 2025-04-29 20:34:48 UTC
The second reproduce should say "To test"...
Comment 3 David Nind 2025-04-30 02:50:43 UTC
Created attachment 181691 [details] [review]
Bug 39782: Add gender label to patron registration form radio buttons

This fixes the patron registration form in the staff interface. There is
no "Gender" label before the radio buttons.

Test plan:
1. Go to Patrons > +New patron > [Select any patron type]
   (http://localhost:8081/cgi-bin/koha/opac-memberentry.pl).
2. In the patron identity section you will see four radio buttons used
   to choose a gender. Note that there is no label next to the buttons.
3. Apply the patch and refresh the page..
4. The label "Gender" is now visible next to the radio buttons.
5. Sign off and have an amazing day! :D

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2025-04-30 02:56:56 UTC
I've amended the commit message (see the commit message guidelines https://wiki.koha-community.org/wiki/Commit_messages)

I've also linked it to the bug that fixes the same issue for the OPAC.
Comment 5 Baptiste Wojtkowski (bwoj) 2025-04-30 11:32:41 UTC
Fine for me, not blocking but would you have time to also align it with the rest of the fields ? It is way better but still a bit weird.
Comment 6 David Nind 2025-04-30 19:05:58 UTC
(In reply to Baptiste Wojtkowski (bwoj) from comment #5)
> Fine for me, not blocking but would you have time to also align it with the
> rest of the fields ? It is way better but still a bit weird.

I think this may be a general style, as other radio button groups are shown the same way (for example, the "Allow auto-renewal of items" yes/no selection).

It uses the class="radio", and has padding-left of 7.5 em (I originally thought it was centred). 

It is used in a lot of places, not just the patron entry form.

For that reason, I think it is outside the scope of this bug - we should create a separate bug for it.

If you agree, I'll create the bug.
Comment 7 Laura Escamilla 2025-04-30 19:30:26 UTC
I agree that the styling is outside the scope of this bug and can be opened as a new bug.
Comment 8 Owen Leonard 2025-05-01 11:10:37 UTC
(In reply to Baptiste Wojtkowski (bwoj) from comment #5)
> Fine for me, not blocking but would you have time to also align it with the
> rest of the fields ? It is way better but still a bit weird.

My hope is that my work on converting forms to use a grid layout is going to make this kind of display better. See Bug 39483.
Comment 9 Katrin Fischer 2025-05-02 06:52:27 UTC
The alignment could be a little nicer, but I believe we can fix later or with Owen's grid work.
Comment 10 Baptiste Wojtkowski (bwoj) 2025-05-02 07:26:36 UTC
Created attachment 181846 [details] [review]
Bug 39782: Add gender label to patron registration form radio buttons

This fixes the patron registration form in the staff interface. There is
no "Gender" label before the radio buttons.

Test plan:
1. Go to Patrons > +New patron > [Select any patron type]
   (http://localhost:8081/cgi-bin/koha/opac-memberentry.pl).
2. In the patron identity section you will see four radio buttons used
   to choose a gender. Note that there is no label next to the buttons.
3. Apply the patch and refresh the page..
4. The label "Gender" is now visible next to the radio buttons.
5. Sign off and have an amazing day! :D

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com>