If there is only one EAN defined, the button has no pulldown. Clicking the button to send the edi order results in the error: No sender ean passed to order creation: basket = Koha::Schema::Result::Aqbasket=HASH(0x5574bf315b98)->basketno()
Created attachment 182036 [details] [review] Bug 39787: Fix missing sender EAN when only one EAN is defined If only one EAN is defined for the library, the Create EDIFACT order button template used the eans.0 object instead of its ean field. As a result, the data-ean attribute contained an object, not the EAN string. Fixed by explicitly accessing the field: eans.0.ean. Steps to reproduce: 1. Ensure only one Library EAN is configured in /cgi-bin/koha/admin/edi_ean_accounts.pl. 2. Create a new basket. 3. Inspect the HTML of the Create EDIFACT order button. 4. The data-ean attribute will show an object instead of EAN string — e.g. Koha::Schema::Result... (this is the bug). 5. Apply the patch and reload the basket page. 6. Inspect the HTML again — data-ean should now show the EAN string (fixed). 7. Click the button, confirm basket closure, then go to EDIFACT messages (/cgi-bin/koha/acqui/edifactmsgs.pl) and verify the message was created.
Created attachment 182067 [details] [review] Bug 39787: Fix missing sender EAN when only one EAN is defined If only one EAN is defined for the library, the Create EDIFACT order button template used the eans.0 object instead of its ean field. As a result, the data-ean attribute contained an object, not the EAN string. Fixed by explicitly accessing the field: eans.0.ean. Steps to reproduce: 1. Ensure only one Library EAN is configured in /cgi-bin/koha/admin/edi_ean_accounts.pl. 2. Create a new basket. 3. Inspect the HTML of the Create EDIFACT order button. 4. The data-ean attribute will show an object instead of EAN string — e.g. Koha::Schema::Result... (this is the bug). 5. Apply the patch and reload the basket page. 6. Inspect the HTML again — data-ean should now show the EAN string (fixed). 7. Click the button, confirm basket closure, then go to EDIFACT messages (/cgi-bin/koha/acqui/edifactmsgs.pl) and verify the message was created. Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using KTD): 1. Enable the EDIFACT system preference. 2. Create an EDI account for "My Vendor" (Koha administration > Acquisition parameters > EDI accounts). 3. Create a library EAN (Koha administration > Acquisition parameters > Library EANs). 4. Then the "Create EDIFACT order" button will appear on the basket page.
Created attachment 182074 [details] [review] Bug 39787: Fix missing sender EAN when only one EAN is defined If only one EAN is defined for the library, the Create EDIFACT order button template used the eans.0 object instead of its ean field. As a result, the data-ean attribute contained an object, not the EAN string. Fixed by explicitly accessing the field: eans.0.ean. Steps to reproduce: 1. Ensure only one Library EAN is configured in /cgi-bin/koha/admin/edi_ean_accounts.pl. 2. Create a new basket. 3. Inspect the HTML of the Create EDIFACT order button. 4. The data-ean attribute will show an object instead of EAN string — e.g. Koha::Schema::Result... (this is the bug). 5. Apply the patch and reload the basket page. 6. Inspect the HTML again — data-ean should now show the EAN string (fixed). 7. Click the button, confirm basket closure, then go to EDIFACT messages (/cgi-bin/koha/acqui/edifactmsgs.pl) and verify the message was created. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Pushed for 25.05! Well done everyone, thank you!