I found while trying to add a contact to a vendor. Not sure if the invoices themselves are relevant. To reproduce: 1. Have a vendor with some invoice 2. Try adding a contact (I added a name and an email) 3. Hit 'Submit' => FAIL: You get a yellow error message about a problem saving. => FAIL: The logs say something like: ``` [2025/05/07 18:08:18] [ERROR] PUT /api/v1/acquisitions/vendors/2: unhandled exception (Koha::Exceptions::Object::PropertyNotFound)<<No property invoices_count for Koha::Acquisition::Bookseller>> ```
Created attachment 182038 [details] [review] Bug 39858: Fix saving vendors with invoices This patch makes the form remove the `invoices_count` attribute from the object before sending it to the API. To test: 1. Have a vendor with some invoice 2. Edit the vendor to add a contact (for example) 3. Click 'Submit' => FAIL: Error, cannot be saved 4. Apply this patch 5. Rebuild the Vue assets: $ ktd --shell k$ yarn js:build 6. Restart: k$ restart_all 7. Reload the browser page and edit the vendor 8. Click 'Submit' => SUCCESS: It saved 9. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 182039 [details] [review] Bug 39858: Fix saving vendors with invoices This patch makes the form remove the `invoices_count` attribute from the object before sending it to the API. To test: 1. Have a vendor with some invoice 2. Edit the vendor to add a contact (for example) 3. Click 'Submit' => FAIL: Error, cannot be saved 4. Apply this patch 5. Rebuild the Vue assets: $ ktd --shell k$ yarn js:build 6. Restart: k$ restart_all 7. Reload the browser page and edit the vendor 8. Click 'Submit' => SUCCESS: It saved 9. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Created attachment 182073 [details] [review] Bug 39858: Fix saving vendors with invoices This patch makes the form remove the `invoices_count` attribute from the object before sending it to the API. To test: 1. Have a vendor with some invoice 2. Edit the vendor to add a contact (for example) 3. Click 'Submit' => FAIL: Error, cannot be saved 4. Apply this patch 5. Rebuild the Vue assets: $ ktd --shell k$ yarn js:build 6. Restart: k$ restart_all 7. Reload the browser page and edit the vendor 8. Click 'Submit' => SUCCESS: It saved 9. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Pushed for 25.05! Well done everyone, thank you!