It seems that when paginating the Z3950 sources table, the event for the delete button is not attached to the second page of results. To recreate: 1 - Add a new Z3950 server with basic information filled out, it doesn't need to be valid 2 - Add a second copy via the DB: INSERT INTO z3950servers SELECT null,host,port,db,userid,password,servername,checked,rank,syntax,timeout,servertype,encoding,recordtype,sru_options,sru_fields,add_xslt,attributes FROM z3950servers WHERE id=6; 3 - Delete the copy, assuming it is on page one, it works 4 - Spam the DB with the SQL above and create 20+ entries 5 - Open the Z3950 admin page 6 - Go to second page of servers 7 - Attempt to delete any entry 8 - Nothing happens
Created attachment 182090 [details] [review] Bug 39861: Delegate click function to the table To test: 1 - Add a new Z3950 server with basic information filled out, it doesn't need to be valid 2 - Add a second copy via the DB: INSERT INTO z3950servers SELECT null,host,port,db,userid,password,servername,checked,rank,syntax,timeout,servertype,encoding,recordtype,sru_options,sru_fields,add_xslt,attributes FROM z3950servers WHERE id=6; 3 - Delete the copy, assuming it is on page one, it works 4 - Spam the DB with the SQL above and create 20+ entries 5 - Open the Z3950 admin page 6 - Go to second page of servers 7 - Attempt to delete any entry 8 - Nothing happens 9 - APPLY PATCH 10 - Try deleting again, it should now work.
Created attachment 182118 [details] [review] Bug 39861: Delegate click function to the table To test: 1 - Add a new Z3950 server with basic information filled out, it doesn't need to be valid 2 - Add a second copy via the DB: INSERT INTO z3950servers SELECT null,host,port,db,userid,password,servername,checked,rank,syntax,timeout,servertype,encoding,recordtype,sru_options,sru_fields,add_xslt,attributes FROM z3950servers WHERE id=6; 3 - Delete the copy, assuming it is on page one, it works 4 - Spam the DB with the SQL above and create 20+ entries 5 - Open the Z3950 admin page 6 - Go to second page of servers 7 - Attempt to delete any entry 8 - Nothing happens 9 - APPLY PATCH 10 - Try deleting again, it should now work. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Created attachment 182119 [details] [review] Bug 39861: Delegate click function to the table To test: 1 - Add a new Z3950 server with basic information filled out, it doesn't need to be valid 2 - Add a second copy via the DB: INSERT INTO z3950servers SELECT null,host,port,db,userid,password,servername,checked,rank,syntax,timeout,servertype,encoding,recordtype,sru_options,sru_fields,add_xslt,attributes FROM z3950servers WHERE id=6; 3 - Delete the copy, assuming it is on page one, it works 4 - Spam the DB with the SQL above and create 20+ entries 5 - Open the Z3950 admin page 6 - Go to second page of servers 7 - Attempt to delete any entry 8 - Nothing happens 9 - APPLY PATCH 10 - Try deleting again, it should now work. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: David Nind <david@davidnind.com>
Trying this out and interestingly it only applies to 20+ entries. If you have 10+ entries and change it to "Show 10 entries", you can delete from the second page. I guess that's because the click handler was added for the original <= 20 entries
Created attachment 182134 [details] [review] Bug 39861: Delegate click function to the table To test: 1 - Add a new Z3950 server with basic information filled out, it doesn't need to be valid 2 - Add a second copy via the DB: INSERT INTO z3950servers SELECT null,host,port,db,userid,password,servername,checked,rank,syntax,timeout,servertype,encoding,recordtype,sru_options,sru_fields,add_xslt,attributes FROM z3950servers WHERE id=6; 3 - Delete the copy, assuming it is on page one, it works 4 - Spam the DB with the SQL above and create 20+ entries 5 - Open the Z3950 admin page 6 - Go to second page of servers 7 - Attempt to delete any entry 8 - Nothing happens 9 - APPLY PATCH 10 - Try deleting again, it should now work. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Cook <dcook@prosentient.com.au>
Pushed for 25.05! Well done everyone, thank you!