Bug 39325 renamed the variable used inside of the FOREACH, but one of the instances was unchanged: [% FOREACH line IN result %] <tr data-authid="[% result.authid | html %]">
Created attachment 182261 [details] [review] Bug 39874: Correct template variable name to fix authority merging This patch correct a template variable name so that the authority record ID is correctly included in the search results table markup. To test, apply the patch and go to Authorities. - Perform a search which will return more than one result. - On one of the results, click Actions -> Merge. - An message should appear at the top, "Merging with authority..." and the authority record ID should be shown in parentheses. - Pick another record in the results list to merge, click Actions -> Merge. - You should be redirected to the "Merging records" page, with the correct two records shown under "Merge reference." Sponsored-by: Athens County Public Libraries
Created attachment 182275 [details] [review] Bug 39874: Correct template variable name to fix authority merging This patch correct a template variable name so that the authority record ID is correctly included in the search results table markup. To test, apply the patch and go to Authorities. - Perform a search which will return more than one result. - On one of the results, click Actions -> Merge. - An message should appear at the top, "Merging with authority..." and the authority record ID should be shown in parentheses. - Pick another record in the results list to merge, click Actions -> Merge. - You should be redirected to the "Merging records" page, with the correct two records shown under "Merge reference." Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com>
Thanks Owen for fixing!
Created attachment 182278 [details] [review] Bug 39874: Correct template variable name to fix authority merging This patch correct a template variable name so that the authority record ID is correctly included in the search results table markup. To test, apply the patch and go to Authorities. - Perform a search which will return more than one result. - On one of the results, click Actions -> Merge. - An message should appear at the top, "Merging with authority..." and the authority record ID should be shown in parentheses. - Pick another record in the results list to merge, click Actions -> Merge. - You should be redirected to the "Merging records" page, with the correct two records shown under "Merge reference." Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Pushed for 25.05! Well done everyone, thank you!