Bug 39881 - Add patron card number to the 'On hold for' column on the transfers to receive page
Summary: Add patron card number to the 'On hold for' column on the transfers to receiv...
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Lucas Gass (lukeg)
QA Contact: Aleisha Amohia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-05-12 19:11 UTC by Lucas Gass (lukeg)
Modified: 2025-07-02 23:16 UTC (History)
5 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement adds the patron's card number to the transfers to receive page for patrons shown in the 'on hold for' column, for item-level holds (Circulation > Transfers > Transfers to receive).
Version(s) released in:
Circulation function:


Attachments
Bug 39881: Add paron cardnumber o ransfers to revceive table (1.77 KB, patch)
2025-05-12 19:14 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 39881: Add paron cardnumber o ransfers to revceive table (1.81 KB, patch)
2025-06-29 21:05 UTC, David Nind
Details | Diff | Splinter Review
Bug 39881: Add paron card number to transfers to receive table (1.82 KB, patch)
2025-06-29 21:07 UTC, David Nind
Details | Diff | Splinter Review
Bug 39881: Add paron card number to transfers to receive table (1.89 KB, patch)
2025-07-01 16:33 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 39881: Add paron card number to transfers to receive table (1.90 KB, patch)
2025-07-01 19:42 UTC, David Nind
Details | Diff | Splinter Review
Bug 39881: Add patron card number to transfers to receive table (1.96 KB, patch)
2025-07-02 23:16 UTC, Aleisha Amohia
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2025-05-12 19:11:47 UTC
It would be nice if the patron's cardnumber was included in the 'On hold for' column on transferstoreceive.tt
Comment 1 Lucas Gass (lukeg) 2025-05-12 19:14:46 UTC
Created attachment 182304 [details] [review]
Bug 39881: Add paron cardnumber o ransfers to revceive table

To test:
0. APPLY PATCH
1. Transfer an item to from Library A to Library B
2. Put on hold on the item
3. Set library to Library B
4. Go to Circulation >  Transfers to receive
5. In the 'ON hold for' column you should see the patron cardnumber now.
Comment 2 David Nind 2025-05-13 02:01:22 UTC
This didn't work for me, not sure if I am testing this correctly:
1. I used Programming perl (current and home library = Centerville, 39999000011418).
2. I used Circulation > Transfers > Transfer, to transfer to Midway:
   - Changed destination library from Centerville to Midway
   - Enter barcode 39999000011418
   - Clicked 'Transfer'
   Result:
   - Table with transferred items is now shown (Origin = Centerville, Destination = Midway)
   - Record holding table shows as "In transit from Centerville to Midway since 05/13/2025"
3. I placed a record-level hold for Mary Burton (Midway), with the pickup location set to Midway.
4. Changed location for koha account from Centerville to Midway (dropdown list in header - far right > cog wheel > choose library - changed to Midway > Submit).
5. Circulation > Transfers > Transfers to receive:
   - "On hold for" column shows as "None"
Comment 3 David Nind 2025-05-13 02:51:22 UTC
Also, the patch title needs fixing...
Comment 4 David Nind 2025-06-29 21:05:49 UTC Comment hidden (obsolete)
Comment 5 David Nind 2025-06-29 21:07:27 UTC
Created attachment 183636 [details] [review]
Bug 39881: Add paron card number to transfers to receive table

To test:
0. APPLY PATCH
1. Transfer an item from Library A to Library B
2. Put on item hold on the item
3. Set library to Library B
4. Go to Circulation >  Transfers to receive
5. In the 'On hold for' column you should now see the patron card number.

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 David Nind 2025-06-29 21:11:06 UTC
(In reply to David Nind from comment #2)
> This didn't work for me, not sure if I am testing this correctly:
> 1. I used Programming perl (current and home library = Centerville,
> 39999000011418).
> 2. I used Circulation > Transfers > Transfer, to transfer to Midway:
>    - Changed destination library from Centerville to Midway
>    - Enter barcode 39999000011418
>    - Clicked 'Transfer'
>    Result:
>    - Table with transferred items is now shown (Origin = Centerville,
> Destination = Midway)
>    - Record holding table shows as "In transit from Centerville to Midway
> since 05/13/2025"
> 3. I placed a record-level hold for Mary Burton (Midway), with the pickup
> location set to Midway.
> 4. Changed location for koha account from Centerville to Midway (dropdown
> list in header - far right > cog wheel > choose library - changed to Midway
> > Submit).
> 5. Circulation > Transfers > Transfers to receive:
>    - "On hold for" column shows as "None"

I retested, for step 3 I placed an item-level hold and the 'On hold for' column now shows "Burton, Mary (212) 555-1212.

Changing to Failed QA, as no card number shown.

Note: I have amended the commit message - title and some of the test plan steps.
Comment 7 Lucas Gass (lukeg) 2025-07-01 16:33:16 UTC
Created attachment 183677 [details] [review]
Bug 39881: Add paron card number to transfers to receive table

To test:
0. APPLY PATCH
1. Transfer an item from Library A to Library B
2. Put on item hold on the item
3. Set library to Library B
4. Go to Circulation >  Transfers to receive
5. In the 'On hold for' column you should now see the patron card number.

Signed-off-by: David Nind <david@davidnind.com>
Comment 8 Lucas Gass (lukeg) 2025-07-01 16:34:11 UTC
> I retested, for step 3 I placed an item-level hold and the 'On hold for'
> column now shows "Burton, Mary (212) 555-1212.
> 
> Changing to Failed QA, as no card number shown.
> 
> Note: I have amended the commit message - title and some of the test plan
> steps.

Thanks David! This should be fixed now.
Comment 9 David Nind 2025-07-01 19:42:51 UTC
Created attachment 183678 [details] [review]
Bug 39881: Add paron card number to transfers to receive table

To test:
0. APPLY PATCH
1. Transfer an item from Library A to Library B
2. Place and item-level hold on the item
3. Set library to Library B
4. Go to Circulation >  Transfers to receive
5. In the 'On hold for' column you should now see the patron card number.

Signed-off-by: David Nind <david@davidnind.com>
Comment 10 David Nind 2025-07-01 19:47:07 UTC
I amended the patch slightly (I didn't do as a follow-up) - changed "Cardnumber:" to "Card number:".
Comment 11 Aleisha Amohia 2025-07-02 23:16:15 UTC
Created attachment 183719 [details] [review]
Bug 39881: Add patron card number to transfers to receive table

To test:
0. APPLY PATCH
1. Transfer an item from Library A to Library B
2. Place and item-level hold on the item
3. Set library to Library B
4. Go to Circulation >  Transfers to receive
5. In the 'On hold for' column you should now see the patron card number.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>