Currently when the pickup location for a hold is changed via the interface or the API we do not rebuild the holds queue. If a hold is to be picked up a new location it may meet LocalHoldsPriority, or there may be an item available. We should trigger a rebuild of the queue whenever the location is updated
Created attachment 182504 [details] [review] Bug 39912: Update RealTimeHoldsQueue when hold pickup location is updated When a hold's pickup location is changed we should rebuild the holds queue. To test: 1 - Enable RealTimeHoldsQueue 2 - Enable LocalHoldsPriority where pickup library matches home library 3 - Place two biblio level holds on a bib with one item for two different patrons for delivery to a different library then the home library 4 - Check the queue - firstpatron should have priority 5 - Change the pickup location for the second hold to be picked up at the home library 6 - Check the queue, unchanged 7 - Change the pickup location back 8 - Apply patch, restart all 9 - Change the pcikup location to the items home library again 10 - Check the queue 11 - Second patron has now been given priority
Created attachment 182683 [details] [review] Bug 39912: Update RealTimeHoldsQueue when hold pickup location is updated When a hold's pickup location is changed we should rebuild the holds queue. To test: 1 - Enable RealTimeHoldsQueue 2 - Enable LocalHoldsPriority where pickup library matches home library 3 - Place two biblio level holds on a bib with one item for two different patrons for delivery to a different library then the home library 4 - Check the queue - firstpatron should have priority 5 - Change the pickup location for the second hold to be picked up at the home library 6 - Check the queue, unchanged 7 - Change the pickup location back 8 - Apply patch, restart all 9 - Change the pcikup location to the items home library again 10 - Check the queue 11 - Second patron has now been given priority Signed-off-by: Michelle Spinney <mspinney@clamsnet.org>
Created attachment 183502 [details] [review] Bug 39912: Update RealTimeHoldsQueue when hold pickup location is updated When a hold's pickup location is changed we should rebuild the holds queue. To test: 1 - Enable RealTimeHoldsQueue 2 - Enable LocalHoldsPriority where pickup library matches home library 3 - Place two biblio level holds on a bib with one item for two different patrons for delivery to a different library then the home library 4 - Check the queue - firstpatron should have priority 5 - Change the pickup location for the second hold to be picked up at the home library 6 - Check the queue, unchanged 7 - Change the pickup location back 8 - Apply patch, restart all 9 - Change the pickup location to the items home library again 10 - Check the queue 11 - Second patron has now been given priority Signed-off-by: Michelle Spinney <mspinney@clamsnet.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Nice work everyone! Pushed to main for 25.11