To recreate: 1. Have some orders that are late. 2. Go to the late orders page ( http://localhost:8081/cgi-bin/koha/acqui/lateorders.pl ) 3. Try to use the export function, nothing happens. Looks to be because the table footer is not correct.
Created attachment 182505 [details] [review] Bug 39914: Correct the footer colspan
Created attachment 182542 [details] [review] Bug 39914: Correct the footer colspan To test: 1. Have some orders that are late. 2. Go to the late orders page ( http://localhost:8081/cgi-bin/koha/acqui/lateorders.pl ) 3. Try to use the export function, nothing happens. 4. APPLY PATCH 5. Try steps 1 and 3 again, this time the export function should work.
Created attachment 182543 [details] [review] Bug 39914: Correct the footer colspan To test: 1. Have some orders that are late. 2. Go to the late orders page ( http://localhost:8081/cgi-bin/koha/acqui/lateorders.pl ) 3. Try to use the export function, nothing happens. 4. APPLY PATCH 5. Try steps 1 and 3 again, this time the export function should work. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 182550 [details] [review] Bug 39914: Correct the footer colspan To test: 1. Have some orders that are late. 2. Go to the late orders page ( http://localhost:8081/cgi-bin/koha/acqui/lateorders.pl ) 3. Try to use the export function, nothing happens. 4. APPLY PATCH 5. Try steps 1 and 3 again, this time the export function should work. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com>
Added my sign-off so that Owen's can be counted as QA.
Created attachment 182551 [details] Screenshot - Lateorders table footer row incorrect offset This isn't quite working correctly for me - the total columns are offset one space to the right (see attached screenshot). The total quantity is aligned with the Total Cost column, and the total cost is pushed over to the Basket column. After some experimentation with showing and hiding different columns on main, the table footer is always the correct size if the ISBN column is hidden, and is always 1 column too small if the ISBN column is showing. Not sure if this is because there's an issue with the ISBN column specifically, or if it's just because the ISBN is the last column, and all we need to do is increase the colspan on the last (blank) footer cell instead of the first footer cell.
Created attachment 182553 [details] [review] Bug 39914: Correct the footer colspan To test: 1. Have some orders that are late. 2. Go to the late orders page ( http://localhost:8081/cgi-bin/koha/acqui/lateorders.pl ) 3. Try to use the export function, nothing happens. 4. APPLY PATCH 5. Try steps 1 and 3 again, this time the export function should work. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Created attachment 182554 [details] [review] Bug 39914: (QA follow-up) Correct the footer colspan on the correct column Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Never mind...the answer to my question was a lot more easily googleable than I thought :D Making the adjustment and setting to PQA. Thanks everyone!
Pushed for 25.05! Well done everyone, thank you!
(In reply to Emily Lamancusa (emlam) from comment #9) > Never mind...the answer to my question was a lot more easily googleable than > I thought :D Making the adjustment and setting to PQA. > > Thanks everyone! Thanks Emily!