Bug 39914 - Can't use table export function on late orders
Summary: Can't use table export function on late orders
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-05-15 20:41 UTC by Lucas Gass (lukeg)
Modified: 2025-05-19 14:02 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the export option for the acquisition's late orders table (Acquisitions > Late orders). Export now works as expected - previously, a progress spinner was shown and the table data was not exported.
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39914: Correct the footer colspan (1.12 KB, patch)
2025-05-15 20:43 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 39914: Correct the footer colspan (1.38 KB, patch)
2025-05-16 15:23 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 39914: Correct the footer colspan (1.44 KB, patch)
2025-05-16 15:32 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 39914: Correct the footer colspan (1.48 KB, patch)
2025-05-16 18:59 UTC, David Nind
Details | Diff | Splinter Review
Screenshot - Lateorders table footer row incorrect offset (84.67 KB, image/png)
2025-05-16 19:29 UTC, Emily Lamancusa (emlam)
Details
Bug 39914: Correct the footer colspan (1.55 KB, patch)
2025-05-16 20:03 UTC, Emily Lamancusa (emlam)
Details | Diff | Splinter Review
Bug 39914: (QA follow-up) Correct the footer colspan on the correct column (1.44 KB, patch)
2025-05-16 20:03 UTC, Emily Lamancusa (emlam)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2025-05-15 20:41:19 UTC
To recreate:

1. Have some orders that are late.
2. Go to the late orders page ( http://localhost:8081/cgi-bin/koha/acqui/lateorders.pl )
3. Try to use the export function, nothing happens. 

Looks to be because the table footer is not correct.
Comment 1 Lucas Gass (lukeg) 2025-05-15 20:43:57 UTC
Created attachment 182505 [details] [review]
Bug 39914: Correct the footer colspan
Comment 2 Lucas Gass (lukeg) 2025-05-16 15:23:35 UTC
Created attachment 182542 [details] [review]
Bug 39914: Correct the footer colspan

To test:
1. Have some orders that are late.
2. Go to the late orders page ( http://localhost:8081/cgi-bin/koha/acqui/lateorders.pl )
3. Try to use the export function, nothing happens.
4. APPLY PATCH
5. Try steps 1 and 3 again, this time the export function should work.
Comment 3 Owen Leonard 2025-05-16 15:32:42 UTC
Created attachment 182543 [details] [review]
Bug 39914: Correct the footer colspan

To test:
1. Have some orders that are late.
2. Go to the late orders page (
   http://localhost:8081/cgi-bin/koha/acqui/lateorders.pl )
3. Try to use the export function, nothing happens.
4. APPLY PATCH
5. Try steps 1 and 3 again, this time the export function should work.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 David Nind 2025-05-16 18:59:32 UTC
Created attachment 182550 [details] [review]
Bug 39914: Correct the footer colspan

To test:
1. Have some orders that are late.
2. Go to the late orders page (
   http://localhost:8081/cgi-bin/koha/acqui/lateorders.pl )
3. Try to use the export function, nothing happens.
4. APPLY PATCH
5. Try steps 1 and 3 again, this time the export function should work.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2025-05-16 19:03:56 UTC
Added my sign-off so that Owen's can be counted as QA.
Comment 6 Emily Lamancusa (emlam) 2025-05-16 19:29:58 UTC
Created attachment 182551 [details]
Screenshot - Lateorders table footer row incorrect offset

This isn't quite working correctly for me - the total columns are offset one space to the right (see attached screenshot). The total quantity is aligned with the Total Cost column, and the total cost is pushed over to the Basket column.

After some experimentation with showing and hiding different columns on main, the table footer is always the correct size if the ISBN column is hidden, and is always 1 column too small if the ISBN column is showing. Not sure if this is because there's an issue with the ISBN column specifically, or if it's just because the ISBN is the last column, and all we need to do is increase the colspan on the last (blank) footer cell instead of the first footer cell.
Comment 7 Emily Lamancusa (emlam) 2025-05-16 20:03:27 UTC
Created attachment 182553 [details] [review]
Bug 39914: Correct the footer colspan

To test:
1. Have some orders that are late.
2. Go to the late orders page (
   http://localhost:8081/cgi-bin/koha/acqui/lateorders.pl )
3. Try to use the export function, nothing happens.
4. APPLY PATCH
5. Try steps 1 and 3 again, this time the export function should work.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 8 Emily Lamancusa (emlam) 2025-05-16 20:03:29 UTC
Created attachment 182554 [details] [review]
Bug 39914: (QA follow-up) Correct the footer colspan on the correct column

Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 9 Emily Lamancusa (emlam) 2025-05-16 20:04:29 UTC
Never mind...the answer to my question was a lot more easily googleable than I thought :D Making the adjustment and setting to PQA.

Thanks everyone!
Comment 10 Katrin Fischer 2025-05-19 07:50:26 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 11 Lucas Gass (lukeg) 2025-05-19 14:02:01 UTC
(In reply to Emily Lamancusa (emlam) from comment #9)
> Never mind...the answer to my question was a lot more easily googleable than
> I thought :D Making the adjustment and setting to PQA.
> 
> Thanks everyone!

Thanks Emily!