Bug 39915 - Late issues export exports empty rows in CSV
Summary: Late issues export exports empty rows in CSV
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Matt Blenkinsop
QA Contact: Testopia
URL:
Keywords:
Depends on: 38829
Blocks:
  Show dependency treegraph
 
Reported: 2025-05-16 09:59 UTC by Matt Blenkinsop
Modified: 2025-05-22 18:37 UTC (History)
1 user (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00,24.11.05
Circulation function:


Attachments
Bug 39915: Restore CSV export of late issues (2.62 KB, patch)
2025-05-16 10:03 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 39915: Restore CSV export of late issues (2.62 KB, patch)
2025-05-16 10:05 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 39915: Restore CSV export of late issues (2.69 KB, patch)
2025-05-16 10:24 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 39915: Restore CSV export of late issues (2.75 KB, patch)
2025-05-16 10:34 UTC, Paul Derscheid
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Blenkinsop 2025-05-16 09:59:40 UTC
To reproduce
1) Create a new subscription, setting the vendor id as 1
2) Set the subscription start date as yesterday's date, the other details aren't relevant so set whatever you want
3) Click into claims
4) If you get a warning saying no claims notice is defined then click the link to define one (on the dropdown for the 'New notice' button you want 'Claim serial issue. The content of the notice isn't relevant here so input anything). Then head back to the claims page. If no warning shows, proceed to the next step
5) Choose My Vendor and hit OK
6) You should see a table of claims with the first issue for your new serial
7) Click the checkbox next to the row
8) Click the 'Download selected claims' button at the bottom
9) The CSV will download
10) Click into it - it will have the header but the rows will be blank
Comment 1 Matt Blenkinsop 2025-05-16 10:00:56 UTC
This is caused by bug 38829 - we return before retrieving the issue if the supplier id is undefined which it always is because we don't pass it in the URL
Comment 2 Matt Blenkinsop 2025-05-16 10:03:31 UTC Comment hidden (obsolete)
Comment 3 Matt Blenkinsop 2025-05-16 10:05:08 UTC
Created attachment 182512 [details] [review]
Bug 39915: Restore CSV export of late issues

This patch restores the ability to export late serial claims to CSV

Test plan:
1) Create a new subscription, setting the vendor id as 1
2) Set the subscription start date as yesterday's date, the other details aren't relevant so set whatever you want
3) Click into claims
4) If you get a warning saying no claims notice is defined then click the link to define one (on the dropdown for the 'New notice' button you want 'Claim serial issue. The content of the notice isn't relevant here so input anything). Then head back to the claims page. If no warning shows, proceed to the next step
5) Choose My Vendor and hit OK
6) You should see a table of claims with the first issue for your new serial
7) Click the checkbox next to the row
8) Click the 'Download selected claims' button at the bottom
9) The CSV will download
10) Click into it - it will have the header but the rows will be blank
11) Apply patch
12) Hard refresh the page
13) Click the download button again
14) Check the new file, the rows will be filled out correctly with data
Comment 4 Owen Leonard 2025-05-16 10:24:49 UTC
Created attachment 182513 [details] [review]
Bug 39915: Restore CSV export of late issues

This patch restores the ability to export late serial claims to CSV

Test plan:
1) Create a new subscription, setting the vendor id as 1
2) Set the subscription start date as yesterday's date, the other
   details aren't relevant so set whatever you want
3) Click into claims
4) If you get a warning saying no claims notice is defined then click
   the link to define one (on the dropdown for the 'New notice' button
   you want 'Claim serial issue. The content of the notice isn't
   relevant here so input anything). Then head back to the claims page.
   If no warning shows, proceed to the next step
5) Choose My Vendor and hit OK
6) You should see a table of claims with the first issue for your new
   serial
7) Click the checkbox next to the row
8) Click the 'Download selected claims' button at the bottom
9) The CSV will download
10) Click into it - it will have the header but the rows will be blank
11) Apply patch
12) Hard refresh the page
13) Click the download button again
14) Check the new file, the rows will be filled out correctly with data

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 5 Paul Derscheid 2025-05-16 10:34:14 UTC
Created attachment 182514 [details] [review]
Bug 39915: Restore CSV export of late issues

This patch restores the ability to export late serial claims to CSV

Test plan:
1) Create a new subscription, setting the vendor id as 1
2) Set the subscription start date as yesterday's date, the other
   details aren't relevant so set whatever you want
3) Click into claims
4) If you get a warning saying no claims notice is defined then click
   the link to define one (on the dropdown for the 'New notice' button
   you want 'Claim serial issue. The content of the notice isn't
   relevant here so input anything). Then head back to the claims page.
   If no warning shows, proceed to the next step
5) Choose My Vendor and hit OK
6) You should see a table of claims with the first issue for your new
   serial
7) Click the checkbox next to the row
8) Click the 'Download selected claims' button at the bottom
9) The CSV will download
10) Click into it - it will have the header but the rows will be blank
11) Apply patch
12) Hard refresh the page
13) Click the download button again
14) Check the new file, the rows will be filled out correctly with data

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 6 Katrin Fischer 2025-05-16 12:27:25 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 7 Paul Derscheid 2025-05-22 18:25:21 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.05