To reproduce 1) Create a new subscription, setting the vendor id as 1 2) Set the subscription start date as yesterday's date, the other details aren't relevant so set whatever you want 3) Click into claims 4) If you get a warning saying no claims notice is defined then click the link to define one (on the dropdown for the 'New notice' button you want 'Claim serial issue. The content of the notice isn't relevant here so input anything). Then head back to the claims page. If no warning shows, proceed to the next step 5) Choose My Vendor and hit OK 6) You should see a table of claims with the first issue for your new serial 7) Click the checkbox next to the row 8) Click the 'Download selected claims' button at the bottom 9) The CSV will download 10) Click into it - it will have the header but the rows will be blank
This is caused by bug 38829 - we return before retrieving the issue if the supplier id is undefined which it always is because we don't pass it in the URL
Created attachment 182511 [details] [review] Bug 39915: Restore CSV export of late issues This patch restores the ability to export late serial claims to CSV Test plan: 1) Create a new subscription, setting the vendor id as 1 2) Set the subscription start date as yesterday's date, the other details aren't relevant so set whatever you want 3) Click into claims 4) If you get a warning saying no claims notice is defined then click the link to define one (on the dropdown for the 'New notice' button you want 'Claim serial issue. The content of the notice isn't relevant here so input anything). Then head back to the claims page. If no warning shows, proceed to the next step 5) Choose My Vendor and hit OK 6) You should see a table of claims with the first issue for your new serial 7) Click the checkbox next to the row 8) Click the 'Download selected claims' button at the bottom 9) The CSV will download 10) Click into it - it will have the header but the rows will be blank 11) Apply patch 12) Hard refresh the page 13) Click the download button again 14) Check the new file, the rows will be filled out correctly with data
Created attachment 182512 [details] [review] Bug 39915: Restore CSV export of late issues This patch restores the ability to export late serial claims to CSV Test plan: 1) Create a new subscription, setting the vendor id as 1 2) Set the subscription start date as yesterday's date, the other details aren't relevant so set whatever you want 3) Click into claims 4) If you get a warning saying no claims notice is defined then click the link to define one (on the dropdown for the 'New notice' button you want 'Claim serial issue. The content of the notice isn't relevant here so input anything). Then head back to the claims page. If no warning shows, proceed to the next step 5) Choose My Vendor and hit OK 6) You should see a table of claims with the first issue for your new serial 7) Click the checkbox next to the row 8) Click the 'Download selected claims' button at the bottom 9) The CSV will download 10) Click into it - it will have the header but the rows will be blank 11) Apply patch 12) Hard refresh the page 13) Click the download button again 14) Check the new file, the rows will be filled out correctly with data
Created attachment 182513 [details] [review] Bug 39915: Restore CSV export of late issues This patch restores the ability to export late serial claims to CSV Test plan: 1) Create a new subscription, setting the vendor id as 1 2) Set the subscription start date as yesterday's date, the other details aren't relevant so set whatever you want 3) Click into claims 4) If you get a warning saying no claims notice is defined then click the link to define one (on the dropdown for the 'New notice' button you want 'Claim serial issue. The content of the notice isn't relevant here so input anything). Then head back to the claims page. If no warning shows, proceed to the next step 5) Choose My Vendor and hit OK 6) You should see a table of claims with the first issue for your new serial 7) Click the checkbox next to the row 8) Click the 'Download selected claims' button at the bottom 9) The CSV will download 10) Click into it - it will have the header but the rows will be blank 11) Apply patch 12) Hard refresh the page 13) Click the download button again 14) Check the new file, the rows will be filled out correctly with data Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 182514 [details] [review] Bug 39915: Restore CSV export of late issues This patch restores the ability to export late serial claims to CSV Test plan: 1) Create a new subscription, setting the vendor id as 1 2) Set the subscription start date as yesterday's date, the other details aren't relevant so set whatever you want 3) Click into claims 4) If you get a warning saying no claims notice is defined then click the link to define one (on the dropdown for the 'New notice' button you want 'Claim serial issue. The content of the notice isn't relevant here so input anything). Then head back to the claims page. If no warning shows, proceed to the next step 5) Choose My Vendor and hit OK 6) You should see a table of claims with the first issue for your new serial 7) Click the checkbox next to the row 8) Click the 'Download selected claims' button at the bottom 9) The CSV will download 10) Click into it - it will have the header but the rows will be blank 11) Apply patch 12) Hard refresh the page 13) Click the download button again 14) Check the new file, the rows will be filled out correctly with data Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Pushed for 25.05! Well done everyone, thank you!
Nice work everyone! Pushed to 24.11.x for 24.11.05