Bug 39954 - Cataloging search results incorrect menu markup
Summary: Cataloging search results incorrect menu markup
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Lisette Scheer
URL:
Keywords: release-notes-needed
Depends on: 35402
Blocks:
  Show dependency treegraph
 
Reported: 2025-05-21 12:37 UTC by Owen Leonard
Modified: 2025-06-30 14:36 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00
Circulation function:


Attachments
Bug 39954: Fix cataloging search results incorrect menu markup (3.44 KB, patch)
2025-05-21 12:56 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 39954: Fix cataloging search results incorrect menu markup (3.49 KB, patch)
2025-05-21 17:29 UTC, Roman Dolny
Details | Diff | Splinter Review
Bug 39954: Fix cataloging search results incorrect menu markup (3.55 KB, patch)
2025-06-27 17:23 UTC, Lisette Scheer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2025-05-21 12:37:19 UTC
In the "Records found in the reservoir" section the "Actions" menus have markup which was not upgraded to Bootstrap 5.
Comment 1 Owen Leonard 2025-05-21 12:56:32 UTC
Created attachment 182689 [details] [review]
Bug 39954: Fix cataloging search results incorrect menu markup

This patch corrects the dropdown menu markup in the "Records found in
the reservoir" section of the cataloging search results page. It was not
upgraded to Bootstrap 5 markup.

To test, apply the patch and go to Cataloging.

- Click "New from Z39.50/SRU"
- Perform a search which will return multiple results.
- Close the popup window and perform the same search in the "Cataloging
  search" header form.
- Scroll down to the "Records found in the reservoir" section.
- Click the "Actions" menu on one of the results. The menu should look
  correct.

Sponsored-by: Athens County Public Libraries
Comment 2 Roman Dolny 2025-05-21 17:29:08 UTC
Created attachment 182699 [details] [review]
Bug 39954: Fix cataloging search results incorrect menu markup

This patch corrects the dropdown menu markup in the "Records found in
the reservoir" section of the cataloging search results page. It was not
upgraded to Bootstrap 5 markup.

To test, apply the patch and go to Cataloging.

- Click "New from Z39.50/SRU"
- Perform a search which will return multiple results.
- Close the popup window and perform the same search in the "Cataloging
  search" header form.
- Scroll down to the "Records found in the reservoir" section.
- Click the "Actions" menu on one of the results. The menu should look
  correct.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 3 Lisette Scheer 2025-06-27 17:23:22 UTC
Created attachment 183617 [details] [review]
Bug 39954: Fix cataloging search results incorrect menu markup

This patch corrects the dropdown menu markup in the "Records found in
the reservoir" section of the cataloging search results page. It was not
upgraded to Bootstrap 5 markup.

To test, apply the patch and go to Cataloging.

- Click "New from Z39.50/SRU"
- Perform a search which will return multiple results.
- Close the popup window and perform the same search in the "Cataloging
  search" header form.
- Scroll down to the "Records found in the reservoir" section.
- Click the "Actions" menu on one of the results. The menu should look
  correct.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Comment 4 Lucas Gass (lukeg) 2025-06-30 14:32:23 UTC
Nice work everyone!

Pushed to main for 25.11