Bug 39984 - Recall notices use the email template to generate SMS notices
Summary: Recall notices use the email template to generate SMS notices
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 23781
Blocks:
  Show dependency treegraph
 
Reported: 2025-05-23 15:48 UTC by Emily Lamancusa (emlam)
Modified: 2025-05-23 15:48 UTC (History)
0 users

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Emily Lamancusa (emlam) 2025-05-23 15:48:08 UTC
Found when testing bug 36020 and replicated on main - the recall notices RETURN_RECALLED_ITEM and PICKUP_RECALLED_ITEM both ignore the SMS notice template, and send the email notice template even when SMS is called for.

To reproduce:
1. Enable UseRecalls syspref and set corresponding circulation rules:
    - Recalls allowed
    - Recalls per record
    - On shelf recalls allowed - set to "If any unavailable"
    - Recall due date interval
    - Recall pickup period
2. Set SMSSendDriver syspref to "Email"
3. Go to Tools > Notices and Slips
4. Edit the notice templates for RETURN_RECALLED_ITEM and PICKUP_RECALLED_ITEM:
    - Make sure both notices have templates defined for email and SMS notices
    - Make sure the email template is different from the SMS template
5. Find or create two patron accounts - Patron A and Patron B
6. Edit the following fields on both patron accounts:
    - Make sure an email address is defined
    - Under Patron Messaging Preferences, enable all Email and SMS notices (no digests)
    - Under Patron Messaging Preferences, enter a phone number for SMS
7. Check out an item to Patron A
8. Log into the OPAC as Patron B
9. Search for the item you checked out in step 5
10. Place a recall on that item
11. In the staff interface, check that item in and confirm the recall
12. Check the Notices tab on Patron A's account
=> You should see two new notices to return a recalled item - one email notice and one SMS notice
13. Look at the previews for the two notices
=> They are the same! :(
14. Check the Notices tab on Patron A's account
=> You should see two new notices to pick up a recalled item - one email notice and one SMS notice
15. Look at the previews for the two notices
=> They are the same! :(