Bug 39996 - [22.11] Subscription cannot be reopened
Summary: [22.11] Subscription cannot be reopened
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: 22.11
Hardware: All All
: P5 - low normal
Assignee: Baptiste Wojtkowski (bwoj)
QA Contact: Testopia
URL:
Keywords: regression
Depends on: 37247
Blocks:
  Show dependency treegraph
 
Reported: 2025-05-26 10:19 UTC by Baptiste Wojtkowski (bwoj)
Modified: 2025-06-25 14:08 UTC (History)
1 user (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 39996: Fix subscription details display (1.08 KB, patch)
2025-05-26 10:33 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Baptiste Wojtkowski (bwoj) 2025-05-26 10:19:16 UTC
Bug 37247 and in particular https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168783&action=diff which use the attribute "subscription.closed" rely on a 23.11 change which passes the subscription object to the template, hence the "close" reopen button is not displayed anymore in 22.11.
Comment 1 Baptiste Wojtkowski (bwoj) 2025-05-26 10:33:49 UTC
Created attachment 182781 [details] [review]
Bug 39996: Fix subscription details display

Test plan (only on a 22.11 !):
1 - Create a subscription, close it.
2 - Visit [YOUR INSTANCE]/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=[THE ID OF THE SUBSCRIPTION] -> there is a "close" button, it is not written closed at the right side of the title
3 - Apply patch
4 - repeat 2, there is no close button but a Reopen button + "(closed)"
  is written after the title
Comment 2 Baptiste Wojtkowski (bwoj) 2025-05-26 10:34:46 UTC
Note: qa script fails at tidying but it would require to change a lot of code before adding just one line.
Comment 3 Katrin Fischer 2025-05-26 10:35:48 UTC
(In reply to Baptiste Wojtkowski (bwoj) from comment #2)
> Note: qa script fails at tidying but it would require to change a lot of
> code before adding just one line.
Comment 4 David Nind 2025-06-16 22:41:05 UTC
I tried to test, but was not able to get a 22.11.x instance running with KTD.
Comment 5 Baptiste Wojtkowski (bwoj) 2025-06-25 14:08:55 UTC
(In reply to Katrin Fischer from comment #3)
> (In reply to Baptiste Wojtkowski (bwoj) from comment #2)
> > Note: qa script fails at tidying but it would require to change a lot of
> > code before adding just one line.

There might have been an error during your answer :)