Bug 40002 - Cannot filter patrons by "Browse by last name"
Summary: Cannot filter patrons by "Browse by last name"
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low critical
Assignee: Jonathan Druart
QA Contact: Lucas Gass (lukeg)
URL:
Keywords:
Depends on: 37334
Blocks:
  Show dependency treegraph
 
Reported: 2025-05-27 08:05 UTC by Jonathan Druart
Modified: 2025-05-28 11:19 UTC (History)
3 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 40002: Fix filtering of patrons by 'Browse by last name' (1.50 KB, patch)
2025-05-27 08:08 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40002: Fix filtering of patrons by 'Browse by last name' (1.56 KB, patch)
2025-05-27 08:33 UTC, Emmi Takkinen
Details | Diff | Splinter Review
Bug 40002: Add a cypress test (1.94 KB, patch)
2025-05-27 09:28 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40002: Fix filtering of patrons by 'Browse by last name' (1.61 KB, patch)
2025-05-27 17:44 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 40002: Add a cypress test (1.99 KB, patch)
2025-05-27 17:44 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2025-05-27 08:05:29 UTC
Caused by

  commit e8129f5aeaa3ca11dcd62cccee0f171209dea605
  Bug 37334: Allow a column filter to be shown even searchable is off
Comment 1 Jonathan Druart 2025-05-27 08:08:28 UTC
Created attachment 182789 [details] [review]
Bug 40002: Fix filtering of patrons by 'Browse by last name'

We cannot longer filter patrons by first letter, the browser errors
"Uncaught TypeError: v.replace is not a function"
Comment 2 Emmi Takkinen 2025-05-27 08:33:15 UTC
Created attachment 182790 [details] [review]
Bug 40002: Fix filtering of patrons by 'Browse by last name'

We cannot longer filter patrons by first letter, the browser errors
"Uncaught TypeError: v.replace is not a function"

Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Comment 3 Emmi Takkinen 2025-05-27 08:33:42 UTC
Tested, this also fixes records holding table.
Comment 4 Jonathan Druart 2025-05-27 09:28:13 UTC
Created attachment 182793 [details] [review]
Bug 40002: Add a cypress test
Comment 5 Jonathan Druart 2025-05-27 09:28:29 UTC
Oops I forgot to attach the tests.
Comment 6 Lucas Gass (lukeg) 2025-05-27 17:41:41 UTC
Also fixes a similar problem in bookings/list.pl
Comment 7 Lucas Gass (lukeg) 2025-05-27 17:44:16 UTC
Created attachment 182804 [details] [review]
Bug 40002: Fix filtering of patrons by 'Browse by last name'

We cannot longer filter patrons by first letter, the browser errors
"Uncaught TypeError: v.replace is not a function"

Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 8 Lucas Gass (lukeg) 2025-05-27 17:44:28 UTC
Created attachment 182805 [details] [review]
Bug 40002: Add a cypress test

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 9 Katrin Fischer 2025-05-28 11:19:31 UTC
Pushed to 25.05.00 - included in the new package v25.05.00-2