rollback ineffective with AutoCommit enabled
Created attachment 182822 [details] [review] Bug 40018: Remove warnings from Koha/Template/Plugin/Koha.t Because we still use CGI::Session (bug 17427), we need to mock CGI::Session to remove those 2 warnings rollback ineffective with AutoCommit enabled Test plan: Run the tests after this patch, it should be green
Created attachment 182823 [details] [review] Bug 40018: Remove warnings from Koha/Template/Plugin/Koha.t Because we still use CGI::Session (bug 17427), we need to mock CGI::Session to remove those 2 warnings rollback ineffective with AutoCommit enabled Test plan: Run the tests after this patch, it should be green
Created attachment 182868 [details] [review] Bug 40018: Remove warnings from Koha/Template/Plugin/Koha.t Because we still use CGI::Session (bug 17427), we need to mock CGI::Session to remove those 2 warnings rollback ineffective with AutoCommit enabled Test plan: Run the tests after this patch, it should be green Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using KTD): 1. Tests pass before and after the patch: prove t/db_dependent/Koha/Template/Plugin/Koha.t 2. Before the patch, there are warnings: prove t/db_dependent/Koha/Template/Plugin/Koha.t t/db_dependent/Koha/Template/Plugin/Koha.t .. rollback ineffective with AutoCommit enabled at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1773. t/db_dependent/Koha/Template/Plugin/Koha.t .. 1/2 rollback ineffective with AutoCommit enabled at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1773. t/db_dependent/Koha/Template/Plugin/Koha.t .. ok All tests successful. Files=1, Tests=2, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.97 cusr 0.16 csys = 1.16 CPU) Result: PASS 3. After the patch, there are no warnings: rove t/db_dependent/Koha/Template/Plugin/Koha.t t/db_dependent/Koha/Template/Plugin/Koha.t .. rollback ineffective with AutoCommit enabled at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1773. t/db_dependent/Koha/Template/Plugin/Koha.t .. 1/2 rollback ineffective with AutoCommit enabled at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1773. t/db_dependent/Koha/Template/Plugin/Koha.t .. ok All tests successful. Files=1, Tests=2, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.97 cusr 0.16 csys = 1.16 CPU) Result: PASS 4. I tested on the latest main.