This is simply based on: https://github.com/mozilla-firefox/firefox/blob/main/.github/workflows/close-pr.yml Automatically redirect users who try to submit a PR at GitHub to instructions on how to submit patches and close the PR. Better experience for potential new developers (since they get immediate feedback, while still in the flow for submitting the patch). The sparse checkout of readme is probably required, so that the gh command knows on what repo to work with. The message text is a combination of the Firefox's text with what people used to write when closing Koha's PRs. I think it should be good enough but of course feel free to share any suggestions for change if you feel like it needs one. TEST PLAN: None honestly. This workflow is proven to work on Firefox's repo. The only change is adding \n newlines to the comment for readability, which I didn't test for whether it works... Otherwise it can only be tested after merging (either to Koha repo or to some dummy test repo if you really want to).
Created attachment 182839 [details] [review] [PATCH] Bug 40027: Use GitHub workflow to automatically close PRs opened on the Koha repo there [PATCH] Bug 40027: Use GitHub workflow to automatically close PRs opened on the Koha repo there Automatically redirect users who try to submit a PR at GitHub to instructions on how to submit patches and close the PR. Better experience for potential new developers (since they get immediate feedback, while still in the flow for submitting the patch). The sparse checkout of readme is probably required, so that the gh command knows on what repo to work with. Based on: https://github.com/mozilla-firefox/firefox/blob/main/.github/workflows/close-pr.yml
Note 1: the presence of .github folder will not impact other git forges. Note 2: the GH_TOKEN: ${{ github.token }} value is populated automatically on workflow's runtime by a temporary token belonging to GitHub Actions user and with a scope permitting basic changes to the repo, so there's no need to manually generate anything.
Created attachment 187386 [details] [review] Bug 40027: Use GitHub workflow to automatically close PRs opened on the Koha repo there Automatically redirect users who try to submit a PR at GitHub to instructions on how to submit patches and close the PR. Better experience for potential new developers (since they get immediate feedback, while still in the flow for submitting the patch). The sparse checkout of readme is probably required, so that the gh command knows on what repo to work with. Based on: https://github.com/mozilla-firefox/firefox/blob/main/.github/workflows/close-pr.yml Signed-off-by: Imani Thomas <imani.thomas@bywatersolutions.com>
Created attachment 187456 [details] [review] Bug 40027: Use GitHub workflow to automatically close PRs opened on the Koha repo there Automatically redirect users who try to submit a PR at GitHub to instructions on how to submit patches and close the PR. Better experience for potential new developers (since they get immediate feedback, while still in the flow for submitting the patch). The sparse checkout of readme is probably required, so that the gh command knows on what repo to work with. Based on: https://github.com/mozilla-firefox/firefox/blob/main/.github/workflows/close-pr.yml Signed-off-by: Imani Thomas <imani.thomas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work everyone! Pushed to main for 25.11
kohadev-koha@kohadevbox:koha(main)$ prove -v /kohadevbox/koha/xt/check_makefile.t /kohadevbox/koha/xt/check_makefile.t .. 1..3 ok 1 - We should test something not ok 2 - All directories must be listed in Makefile.PL # Failed test 'All directories must be listed in Makefile.PL' # at /kohadevbox/koha/xt/check_makefile.t line 40. # got: '1' # expected: '0' # $VAR1 = [ # '.github' # ]; ok 3 - no warnings # Looks like you failed 1 test of 3. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests Do we need to add the .github dir to Makefile.PL?
Created attachment 187493 [details] [review] Bug 40027: (follow-up) Add .github/ to Makefile.PL Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
follow-up pushed to main
Nice work everyone! Pushed to 25.05.x
Pushed to 24.11.x for 24.11.11