Created attachment 182862 [details] [review] Bug 40037: Remove redundant check in `notices_content` hook handling I reused an implemented hook in C4::Letters and overlooked the redundancy in it. This patch clears that. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Plugins/Notices_content_hook.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! No behavior change! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 182863 [details] [review] Bug 40037: (follow-up) Remove redundancy in `before_send_messages` Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
I did a grep for `@plugins` on the codebase and these seem to be the only places this pattern was used.
Created attachment 182864 [details] [review] Bug 40037: Remove redundant check in `notices_content` hook handling I reused an implemented hook in C4::Letters and overlooked the redundancy in it. This patch clears that. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Plugins/Notices_content_hook.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! No behavior change! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 182865 [details] [review] Bug 40037: (follow-up) Remove redundancy in `before_send_messages` Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>