Bug 40041 - Update mailmap for 25.11.x
Summary: Update mailmap for 25.11.x
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low trivial
Assignee: Martin Renvoize (ashimema)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-06-02 06:30 UTC by Martin Renvoize (ashimema)
Modified: 2025-06-09 20:19 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 40041: Update .mailmap (1.93 KB, patch)
2025-06-02 06:33 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 40041: mailmap fixes and tidy (19.03 KB, patch)
2025-06-04 14:29 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2025-06-02 06:30:24 UTC
We missed a few mailmap bits in the 25.05.x release
Comment 1 Martin Renvoize (ashimema) 2025-06-02 06:33:04 UTC
Created attachment 182895 [details] [review]
Bug 40041: Update .mailmap

Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 2 Tomás Cohen Arazi (tcohen) 2025-06-04 14:29:01 UTC
Created attachment 182952 [details] [review]
Bug 40041: mailmap fixes and tidy

This patch fixes a couple errors I found in mailmap.

Canonical names are added to some emails. Not 100% they are required,
but they make sense anyway (i.e. if someone from OpenFifth forgets to
set their name, we want the log/release notes to display it correctly
regardless).

A good example for the need of a canonical mapping is "Sam
<samalau@gmail.com>" which we really want to display "Sam Lau" even if
they missed to put the complete name. That's when a canonical mapping
serves its purpose.

To test:
1. Run:
   $ for i in colin.campbell@openfifth.co.uk chloe.zermatten@openfifth.co.uk martin.renvoize@openfifth.co.uk aude.charillon@openfifth.co.uk andrew.isherwood@ptfs-europe.com matt.blenkinsop@openfifth.co.uk matt.blenkinsip@ptfs-europe.com matt.blenkinsop@ptfs-europe.com andrew.auld@ptfs-europe.com pedro.amorim@ptfs-europe.com msaby mathsabypro@gmail.com marjorie.barry-vila@collecto.ca andrew.auld@openfifth.co.uk catrina@bywatersolutions.com felicie.thiery@biblibre.com janne.seppanen@lahti.fi jesse@bywatersolutions.com kelly@bywatersolutions.com laurence.rault@biblibre.com samalau@gmail.com ; do git check-mailmap -- $i ; done
=> FAIL: They don't show correctly
2. Apply this patch
3. Repeat 1
=> SUCESS: They display correctly now
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 David Nind 2025-06-05 00:26:11 UTC
Not sure how to run the commands in step 1 of the test plan - pasting it into the command line gives this error:

fatal: unable to parse contact: colin.campbell@openfifth.co.uk
fatal: unable to parse contact: chloe.zermatten@openfifth.co.uk
....
Comment 4 Tomás Cohen Arazi (tcohen) 2025-06-06 18:00:27 UTC
(In reply to David Nind from comment #3)
> Not sure how to run the commands in step 1 of the test plan - pasting it
> into the command line gives this error:
> 
> fatal: unable to parse contact: colin.campbell@openfifth.co.uk
> fatal: unable to parse contact: chloe.zermatten@openfifth.co.uk
> ....

Ohhh. It depends on the git version!

* git version 2.49.0: OK
* git version 2.39.5 (KTD/bookworm): Error

What do we so @ashimema?