Bug 40114 - Can't select new library when editing a desk
Summary: Can't select new library when editing a desk
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Lucas Gass (lukeg)
URL:
Keywords:
Depends on:
Blocks: 40113
  Show dependency treegraph
 
Reported: 2025-06-10 18:41 UTC by Owen Leonard
Modified: 2025-07-25 20:39 UTC (History)
3 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This patch fixes a problem that made it impossible to select a new library/branch when editing a desk from Administration -> Desks.
Version(s) released in:
25.11.00
Circulation function:


Attachments
Bug 40114: Can't select new library when editing a desk (2.57 KB, patch)
2025-06-10 18:46 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 40114: Can't select new library when editing a desk (2.62 KB, patch)
2025-07-25 17:17 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2025-06-10 18:41:51 UTC
When editing a desk, the "Library" <select> only includes one option, the existing value.
Comment 1 Owen Leonard 2025-06-10 18:46:22 UTC
Created attachment 183147 [details] [review]
Bug 40114: Can't select new library when editing a desk

This patch fixes selection of a library when editing a desk in
Administration. The form should provide all libraries as options, not
just the currently selected one.

To test, apply the patch and go to Administration -> Desks.

- If necessary, create a new desk.
- Edit the desk. The form should load with the correct library prefilled
  in the <select>, but should offer all libraries as a choices.

Sponsored-by: Athens County Public Libraries
Comment 2 Esther Melander 2025-06-11 16:20:51 UTC
The test plan appeared to work.

Signed off by: Esther Melander <esther@bywatersolutions.com>
Comment 3 Lucas Gass (lukeg) 2025-07-25 17:17:39 UTC
Created attachment 184656 [details] [review]
Bug 40114: Can't select new library when editing a desk

This patch fixes selection of a library when editing a desk in
Administration. The form should provide all libraries as options, not
just the currently selected one.

To test, apply the patch and go to Administration -> Desks.

- If necessary, create a new desk.
- Edit the desk. The form should load with the correct library prefilled
  in the <select>, but should offer all libraries as a choices.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Lucas Gass (lukeg) 2025-07-25 20:39:45 UTC
Nice work everyone!

Pushed to main for 25.11